Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging: add GetLogger function #112

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

vbmithr
Copy link

@vbmithr vbmithr commented Dec 3, 2024

I needed this function in order to use SetConfigAndRebuild and apply my custom Zap config to existing aeron loggers (to have uniform logging style with my own client app).

@vbmithr vbmithr marked this pull request as draft December 3, 2024 23:07
@vbmithr
Copy link
Author

vbmithr commented Dec 3, 2024

I think it would also be nice to add a function to set a logger config to all aeron internal loggers created by MustGetLogger, what do you think @ethanf ?

@ethanf
Copy link
Collaborator

ethanf commented Dec 11, 2024

I think it would also be nice to add a function to set a logger config to all aeron internal loggers created by MustGetLogger, what do you think @ethanf ?

I think this makes sense, do you have an example for how to use this in a test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants