Fix textDocument/formatting operations
#98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `TextEdit` ranges don't consider the intermediate doc states, so applying them in reverse order (from bottom to top) should result in edits occurring at the intended locations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86.
Also this applies formatting
TextEdits in reverse order (from bottom to top) which should result in edits occurring at the intended locations.This assumes that the
TextEdits are sent by the servers already sorted. If this ends up to not be the case for all servers, we'll add range sorting code.TODO: for servers that just send a single big
TextEdit, we should find some heuristic to move the cursor to an appropriate location (maybe trying to keep it on the same line+col would be enough). See #31.