Improve handling of time #347
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ismailToyran
commented
Jul 20, 2023
|
|
||
| function MyApp({ Component, pageProps }: AppProps<MyAppProps>): JSX.Element { | ||
| const mountTime = useConst(() => new Date()) |
There was a problem hiding this comment.
@antho1404 what do you think about this usage?
Am I missing something on _document.tsx file that this now is required there?
Simply having one mount time and spreading this Date should fix the issues right?
There was a problem hiding this comment.
that sound interesting, I didn't know about that. I am worried that this will not be shared between ssr and client but I will do some tests
|
Closing in favor of #432 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project organization
Description
Uses
useConsthook from Chakra to get mountTime on_app.tsxfile and spread that across the app.https://chakra-ui.com/docs/hooks/use-const
Checklist
dev