Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cart system #471

Merged
merged 79 commits into from
Jan 10, 2024
Merged

Cart system #471

merged 79 commits into from
Jan 10, 2024

Conversation

antho1404
Copy link
Member

@antho1404 antho1404 commented Nov 7, 2023

Test:

These tests should be done for all testnet chains (Ethereum, Binance Smart Chain, Polygon, Lightlink)

You can reset your approvals here https://revoke.cash/

| Test Case                                           | Expected Result                      | Actual Result | Status | Notes |
| --------------------------------------------------- | ------------------------------------ | ------------- | ------ | ----- |
| Add item to cart                                    | Item added successfully              |               |        |       |
| Remove item from cart                               | Item removed successfully            |               |        |       |
| Clear cart                                          | Cart cleared successfully            |               |        |       |
| Add item from various chains                        | Item added successfully              |               |        |       |
| Add item with native token                          | Item added successfully              |               |        |       |
| Add item with ERC20 token                           | Item added successfully              |               |        |       |
| Purchase items with only native token               | Purchase successful                  |               |        |       |
| Purchase items with only ERC20 token                | Purchase successful                  |               |        |       |
| Purchase items with a mix of ERC20 and native token | Purchase successful                  |               |        |       |
| Purchase items with no approval on the ERC20        | Purchase fails/has expected behavior |               |        |       |
| Verify account activity                             | Account activity accurate            |               |        |       |
| Verify payment in the dashboard                     | Payment reflected correctly          |               |        |       |

Please approve the PR when you have tested it, and everything is good to go.
Also please put a 👍 when you started the tests
If you see anything not critical, please add it to issue #489 and do not put that on this PR

@antho1404 antho1404 changed the base branch from main to dev November 7, 2023 13:42
Copy link
Member

@NicolasMahe NicolasMahe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working good 👍
I reopen a comment about the refresh of NFT that is trigger too early to continue the conversation over there.
I put my other non-blocking feedbacks on #489

Batch purchase on LightLink Pegasus is returning error because wrapper is not gas-free yet. I contacted them to add it.

Test Case Expected Result Actual Result Status Notes
Add item to cart Item added successfully Working
Remove item from cart Item removed successfully Working
Clear cart Cart cleared successfully Working
Add item from various chains Item added successfully Working
Add item with native token Item added successfully Working
Add item with ERC20 token Item added successfully Working
Purchase items with only native token Purchase successful Working
Purchase items with only ERC20 token Purchase successful Working
Purchase items with a mix of ERC20 and native token Purchase successful Working
Purchase items with no approval on the ERC20 Purchase fails/has expected behavior Working
Verify account activity Account activity accurate Working
Verify payment in the dashboard Payment reflected correctly Working

@ismailToyran
Copy link
Contributor

ismailToyran commented Nov 29, 2023

  • I was at explore page with filtered buy now items. After doing transaction, currently bought item didn't refresh and was still shown on the page. There was a fix for this one but I guess didn't work for me on this batch purchase.
  • While getting approval status of currencies, there is no text on the footer button. Looks buggy.

image

  • Same error as Nicolas, need to manually refresh after navigation from homepage (click link and refresh to navigate) otherwise it doesn't work right now. Fix and improve cart callback #499

Rest is working great as expected.

@EmmanuelDrouin
Copy link
Member

EmmanuelDrouin commented Dec 8, 2023

My testing

Test Case Expected Result Actual Result Status Notes
Add item to cart Item added successfully Working
Remove item from cart Item removed successfully Working
Clear cart Cart cleared successfully Working
Add item from various chains Item added successfully Working
Add item with native token Item added successfully Working
Add item with ERC20 token Item added successfully Working
Purchase items with only native token Purchase successful Working
Purchase items with only ERC20 token Purchase successful Working
Purchase items with a mix of ERC20 and native token Purchase successful Working
Purchase items with no approval on the ERC20 Purchase fails/has expected behavior Working
Verify account activity Account activity accurate Working
Verify payment in the dashboard Payment reflected correctly Working

Copy link
Contributor

@ismailToyran ismailToyran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's gooo 🎉

@ismailToyran ismailToyran added this pull request to the merge queue Jan 10, 2024
Merged via the queue into dev with commit 4147ff9 Jan 10, 2024
@ismailToyran ismailToyran deleted the feature/cart-system branch January 10, 2024 07:59
@ismailToyran ismailToyran mentioned this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants