-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cart system #471
Cart system #471
Conversation
Add base for cart system
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working good 👍
I reopen a comment about the refresh of NFT that is trigger too early to continue the conversation over there.
I put my other non-blocking feedbacks on #489
Batch purchase on LightLink Pegasus is returning error because wrapper is not gas-free yet. I contacted them to add it.
Test Case | Expected Result | Actual Result | Status | Notes |
---|---|---|---|---|
Add item to cart | Item added successfully | Working | ||
Remove item from cart | Item removed successfully | Working | ||
Clear cart | Cart cleared successfully | Working | ||
Add item from various chains | Item added successfully | Working | ||
Add item with native token | Item added successfully | Working | ||
Add item with ERC20 token | Item added successfully | Working | ||
Purchase items with only native token | Purchase successful | Working | ||
Purchase items with only ERC20 token | Purchase successful | Working | ||
Purchase items with a mix of ERC20 and native token | Purchase successful | Working | ||
Purchase items with no approval on the ERC20 | Purchase fails/has expected behavior | Working | ||
Verify account activity | Account activity accurate | Working | ||
Verify payment in the dashboard | Payment reflected correctly | Working |
Rest is working great as expected. |
… the context is closed
Fix and improve cart callback
My testing
|
Fix button loading state when approving currencies for cart
…hase-feature use useBatchPurchase from the library
649e3c9
to
9b51316
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's gooo 🎉
Test:
These tests should be done for all testnet chains (Ethereum, Binance Smart Chain, Polygon, Lightlink)
You can reset your approvals here https://revoke.cash/
Please approve the PR when you have tested it, and everything is good to go.
Also please put a 👍 when you started the tests
If you see anything not critical, please add it to issue #489 and do not put that on this PR