-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split TEE release into worker and enclave #2217
Split TEE release into worker and enclave #2217
Conversation
P-193 Split enclave release into worker and runtime
So far the enclave is released "as a whole" which has a unified version. Similar to parachain, we should divide it into two parts: the worker (non-enclave) part and runtime (enclave logic) part. It's possible that one of these needs an update while the other is kept unchanged, so we need to handle them separately. So instead of current release item list (see an example here), which is:
I suggest:
Ideally, the versions of tee-worker and tee-enclave will match each other, suggestion:
We follow a similar naming mechanism to parachain, but reserve the last two digits for enclave update as it's supposed to be much more frequent than the worker update. Suggested additional information in release log:
Each time we change the enclave logic (which should result in a different From the ts-packages' perspective, they should follow the version of parachain-runtime and tee-enclave, and rebuild the package whenever either of them changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tried it out but it looks fine.
Context
This PR:
enclave.signed.so
andlitentry-worker
are the only things to release (= made public)0.0.1
100
We should bump the enclave runtime version for any change that results in a different MRENCLAVE, even if it's not a direct sgx-pallet/runtime change.
TODO:
SGX_SIGN_PASSFILE
is ignored for now, we need to figure out how/if we should use it => an issue will followA trial run that builds all 4 artefacts:
https://github.com/litentry/litentry-parachain/releases/tag/untagged-e92681d128065981fdb1