Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change precondition of LITStaking VC value being true #2805

Merged
merged 2 commits into from
Jun 15, 2024

Conversation

higherordertech
Copy link
Contributor

to require amount to be greater than 0

Context

Labels

Please apply following PR-related labels when appropriate:

  • C0-breaking: if your change could break the existing client, e.g. API change, critical logic change
  • C1-noteworthy: if your change is non-breaking, but is still worth noticing for the client, e.g. reference code improvement

How (Optional)

Testing Evidences

Please attach any relevant evidences if applicable

Copy link
Contributor

@jonalvarezz jonalvarezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any chance we can add tests to prevent it from happening again?

@Kailai-Wang
Copy link
Collaborator

any chance we can add tests to prevent it from happening again?

maybe @0xverin knows more - does our data provider test cover this case?

@higherordertech higherordertech requested review from a team and removed request for outofxxx June 13, 2024 00:26
@higherordertech higherordertech enabled auto-merge (squash) June 14, 2024 00:55
@higherordertech higherordertech merged commit be5aa82 into dev Jun 15, 2024
33 checks passed
@Kailai-Wang Kailai-Wang deleted the fix-LITStaking-vc branch June 15, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants