-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Erc20 contracts #2811
Conversation
…tentry-parachain into token-holding-amount
I browsed the whole structure, it seems to be well desigend and made, nicely done We'll need @kziemianek and @higherordertech to check more details 🙌 |
...rker/litentry/core/assertion-build/src/dynamic/contracts/token_holding_amount/erc20/Wbtc.sol
Outdated
Show resolved
Hide resolved
return (false, 0); | ||
} | ||
} | ||
function getTokenBalance( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted it to have 1 function per 1 rpc method but that's fine too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not very convenient to use externally, and requires a lot of if statements, so I merged them here.
b78497a
to
2941a9f
Compare
2941a9f
to
224926a
Compare
Context
resolves p-845
resolves p-846
This PR mainly implements the ERC20 contract on BSC and Ethereum networks.
Labels
Please apply following PR-related labels when appropriate:
C0-breaking
: if your change could break the existing client, e.g. API change, critical logic changeC1-noteworthy
: if your change is non-breaking, but is still worth noticing for the client, e.g. reference code improvementHow (Optional)
Testing Evidences
generate vc:
erc20(trx):
native token(bnb):
TODO: Add all tokens.All tokens have been added, reference from rust code.