-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support to send batch extrinsics to the parachain #2825
Adding support to send batch extrinsics to the parachain #2825
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! The logic looks fine, only have questions regarding the batch parameters
tee-worker/litentry/core/parachain-extrinsic-task/receiver/src/lib.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, LGTM.
Except "too many calls", just one more point: are we considering to not use such global variables GLOBAL_PARACHAIN_EXTRINSIC_TASK
in the future?
maybe @Kailai-Wang have any idea?
tee-worker/litentry/core/parachain-extrinsic-task/receiver/src/lib.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve it as it's in any case an improvement to current structure.
there should be a limit of byte array size going through the ocall
Please double-check it and/or change the limit
Shall we use this thread to send other extrinsics? Like teebag callbacks? My preference is yes.
Currently it's often used as:
self.validator_accessor
.execute_mut_on_validator(|v| v.send_extrinsics(parentchain_extrinsics))?;
Does it have the same effect as having this global thread?
The limit for |
So, there are a couple of differences: The other difference is the nature of the interval batching, if we are Ok with eventual consistency there should be no problem. @Kailai-Wang Should I make the changes to send all extrinsics to the new thread as part of this PR? or should we create a follow up issue? |
Please do it in a separate PR : ) |
As topic: This PR adds the structure to send batch extrinsics to the parachain asynchronously. Starting with
vc_issued