Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement access control for AccountStore members #3204

Merged
merged 29 commits into from
Dec 26, 2024
Merged

Implement access control for AccountStore members #3204

merged 29 commits into from
Dec 26, 2024

Conversation

silva-fj
Copy link
Contributor

@silva-fj silva-fj commented Dec 13, 2024 •
edited
Loading

As topic, this PR introduces an access control mechanism for the OmniAccount (AccountStore) members.

@silva-fj silva-fj requested review from kziemianek, Kailai-Wang and a team December 13, 2024 17:06
@linear Linear
Copy link

linear bot commented Dec 13, 2024 •
edited by silva-fj
Loading

P-1229 Implement access control for AccountStore members in the omni-account pallet

@silva-fj silva-fj force-pushed the p-1240-implement-access-control-for-accountstore-members-in-the branch from d9a4b41 to 8cabe70 Compare December 16, 2024 09:34
@silva-fj silva-fj mentioned this pull request Dec 17, 2024
Merged
BillyWooo
BillyWooo approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@BillyWooo BillyWooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, LGTM. Left one comment.

@silva-fj
using single storage unbounded instead of pallet::without_storage_info
8641e0b
@silva-fj
adding integrity_test hook
ce5ab39
@silva-fj
adding new types to the pallet config
3758f5d
@silva-fj
adding storage item for account member permissions
110c330
@silva-fj
adding new errors
c8adeac
@silva-fj
storing default permission on create_account_store
38f3a1f
@silva-fj
adding comments
c06f446
@silva-fj
adding default permissions
8d6018b
@silva-fj
small refactoring
0aeebe3
@silva-fj
implementing ensure_permission
b584d83
@silva-fj
updating mock
959c83d
@silva-fj
adding optional permissions to add_account, set defaults if None
5cb8eed
@silva-fj
setting permissions on update_account_store_by_one
7b619e2
@silva-fj
improving ensure_permission
6200570
@silva-fj
updating mock
d76187c
@silva-fj
refactoring add_account_call util
d8cfd2c
@silva-fj
adding tests for permissions
c86a12f
@silva-fj
updating mock
91ae891
@silva-fj
adding Permission type to runtimes
60d0199
@silva-fj
updating permissions mock and tests
7ae5959
@silva-fj
adding set_permissions call
f729738
@silva-fj silva-fj force-pushed the p-1240-implement-access-control-for-accountstore-members-in-the branch from 35786aa to a4876f1 Compare December 24, 2024 09:04
@Kailai-Wang
Copy link
Collaborator

Thanks, we are good to go once conflicts are resolved

@silva-fj silva-fj enabled auto-merge (squash) December 26, 2024 10:43
@silva-fj silva-fj merged commit ba685cc into dev Dec 26, 2024
20 of 22 checks passed
@silva-fj silva-fj deleted the p-1240-implement-access-control-for-accountstore-members-in-the branch December 26, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyWooo BillyWooo BillyWooo approved these changes

@Kailai-Wang Kailai-Wang Kailai-Wang approved these changes

@kziemianek kziemianek Awaiting requested review from kziemianek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@silva-fj @Kailai-Wang @BillyWooo