Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix post-checks test script environment variable #3212

Merged
merged 3 commits into from
Dec 31, 2024
Merged

Conversation

0xverin
Copy link
Contributor

@0xverin 0xverin commented Dec 19, 2024

The start script always uses the config's settings, causing the script's environment variables to not work.

@0xverin 0xverin requested a review from BillyWooo December 19, 2024 09:09
@0xverin 0xverin changed the title Fix the issue where the post-checks test environment variable is not working. Fix post-checks test script environment variable is not working. Dec 19, 2024
@0xverin 0xverin changed the title Fix post-checks test script environment variable is not working. Fix post-checks test script environment variable Dec 19, 2024
@Kailai-Wang
Copy link
Collaborator

Can this be merged? @0xverin @BillyWooo

@BillyWooo
Copy link
Collaborator

Can this be merged? @0xverin @BillyWooo

Yes. Let's merge this one.
Even though post-check still has other problem. But this PR can be merged first. It fix the env parameter input issue.

@BillyWooo BillyWooo merged commit 96a2716 into dev Dec 31, 2024
22 checks passed
@BillyWooo BillyWooo deleted the fix-post-checks branch December 31, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants