Adding native_submitPlainRequest RPC method #3245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move authentication code from submit_aes_request to a separate module to improve code organization and reusability. The new module native_call_authenticated.rs contains the authentication logic and data structures previously embedded in submit_aes_request.rs.
Improve code readability for AES request handler by: - Reducing variable shadowing by using block scoping in spawn_blocking - Making error message more consistent with other error messages
Add new RPC method native_submitPlainRequest to handle unencrypted requests: - Add PlainRequest struct to represent unencrypted requests - Register new method in RPC module - Implement authentication verification for plain requests - Handle native task execution and response handling
kziemianek
reviewed
Jan 31, 2025
references for shard and simplifying the signature verification
kziemianek
approved these changes
Feb 3, 2025
tee-worker/omni-executor/rpc-server/src/methods/submit_plain_request.rs
Outdated
Show resolved
Hide resolved
tee-worker/omni-executor/rpc-server/src/methods/submit_plain_request.rs
Outdated
Show resolved
Hide resolved
Yep, we'll do in a separate PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new rpc method to submit plain (unencrypted) requests for native calls as well some small refactoring.