Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(24-platform-user): add MagicCraft #35

Merged
merged 4 commits into from
May 12, 2024
Merged

feat(24-platform-user): add MagicCraft #35

merged 4 commits into from
May 12, 2024

Conversation

jonalvarezz
Copy link
Contributor

Additional changes:

  • Add a contributing section to the README.
  • Add missing entries to the CHANGELOG

@jonalvarezz
24-platform-user: addition magiccraft
4160bbf 
Signed-off-by: Jonathan Alvarez <[email protected]>
@jonalvarezz
generate
2089aa9 
Signed-off-by: Jonathan Alvarez <[email protected]>
@jonalvarezz
update changelog
3186013 
Signed-off-by: Jonathan Alvarez <[email protected]>
@jonalvarezz
add contributing section
72a822b 
Signed-off-by: Jonathan Alvarez <[email protected]>
@jonalvarezz jonalvarezz requested a review from BillyWooo May 10, 2024 13:43
@linear Linear
Copy link

linear bot commented May 10, 2024

P-716 Magiccraft staking credential

@jonalvarezz
Copy link
Contributor Author

Hi @BillyWooo, I noticed you pushed the JSON schema directly to the repo via commit dad1888.

We describe the model in packages/schema and then run a command that yields all the JSON files.

This Pull Request creates the model to support MagicCraft. With no model the JSON you added would dissapear on the next generate command run 😄

BillyWooo
BillyWooo approved these changes May 12, 2024
View reviewed changes
Copy link
Contributor

@BillyWooo BillyWooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BillyWooo BillyWooo merged commit a5b2525 into main May 12, 2024
2 checks passed
@BillyWooo BillyWooo deleted the p-716-magiccraft-schema branch May 12, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyWooo BillyWooo BillyWooo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonalvarezz @BillyWooo