Skip to content

Fix clippy

Fix clippy #7564

GitHub Actions / clippy failed Jun 20, 2024 in 0s

clippy

5 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 5
Warning 0
Note 0
Help 0

Versions

  • rustc 1.79.0 (129f3b996 2024-06-10)
  • cargo 1.79.0 (ffa9cf99a 2024-06-03)
  • clippy 0.1.79 (129f3b9 2024-06-10)

Annotations

Check failure on line 199 in crates/maple_core/src/stdio_server/provider/impls/lsp.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `container_name` is never read

error: field `container_name` is never read
   --> crates/maple_core/src/stdio_server/provider/impls/lsp.rs:199:9
    |
194 | pub struct WorkspaceItem {
    |            ------------- field in this struct
...
199 |     pub container_name: Option<String>,
    |         ^^^^^^^^^^^^^^
    |
    = note: `WorkspaceItem` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis

Check failure on line 150 in crates/maple_core/src/stdio_server/provider/impls/lsp.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `container_name` is never read

error: field `container_name` is never read
   --> crates/maple_core/src/stdio_server/provider/impls/lsp.rs:150:9
    |
146 | pub struct DocumentItem {
    |            ------------ field in this struct
...
150 |     pub container_name: Option<String>,
    |         ^^^^^^^^^^^^^^
    |
    = note: `DocumentItem` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis

Check failure on line 126 in crates/maple_core/src/stdio_server/provider/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

fields `start` and `input` are never read

error: fields `start` and `input` are never read
   --> crates/maple_core/src/stdio_server/provider/mod.rs:126:9
    |
122 | pub struct ProviderEnvironment {
    |            ------------------- fields in this struct
...
126 |     pub start: BufnrWinid,
    |         ^^^^^
127 |     pub input: BufnrWinid,
    |         ^^^^^
    |
    = note: `ProviderEnvironment` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
    = note: `-D dead-code` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(dead_code)]`

Check failure on line 260 in crates/maple_core/src/stdio_server/plugin/git.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `if` statement can be collapsed

error: this `if` statement can be collapsed
   --> crates/maple_core/src/stdio_server/plugin/git.rs:255:17
    |
255 | /                 if filepath.canonicalize()?.starts_with(&git.repo) {
256 | |                     if git.is_tracked(filepath).unwrap_or(false) {
257 | |                         self.vim
258 | |                             .exec("clap#plugin#git#set_branch_var", (bufnr, branch.trim()))?;
259 | |                     }
260 | |                 }
    | |_________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
    = note: `-D clippy::collapsible-if` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::collapsible_if)]`
help: collapse nested if block
    |
255 ~                 if filepath.canonicalize()?.starts_with(&git.repo) && git.is_tracked(filepath).unwrap_or(false) {
256 +                     self.vim
257 +                         .exec("clap#plugin#git#set_branch_var", (bufnr, branch.trim()))?;
258 +                 }
    |

Check failure on line 11 in crates/upgrade/src/github.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `browser_download_url` is never read

error: field `browser_download_url` is never read
  --> crates/upgrade/src/github.rs:11:9
   |
8  | pub struct Asset {
   |            ----- field in this struct
...
11 |     pub browser_download_url: String,
   |         ^^^^^^^^^^^^^^^^^^^^
   |
   = note: `Asset` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
   = note: `-D dead-code` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(dead_code)]`