Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pro-field #141

Merged
merged 2 commits into from
Nov 14, 2024
Merged

feat: pro-field #141

merged 2 commits into from
Nov 14, 2024

Conversation

liujiayii
Copy link
Owner

@liujiayii liujiayii commented Nov 14, 2024

Summary by CodeRabbit

  • 新功能

    • 更新了多个组件(如 DateTime、Money、Select 等)以支持计算属性的值注入,增强了组件的响应性和数据处理能力。
  • 文档

    • 更新了 ProFieldProps 接口中的 value 属性类型,从 any 更改为 ComputedRef<any>,以反映新的数据结构要求。
  • 重构

    • Table.tsx 中移除了 formatTableColumns 函数,将其逻辑直接集成到 computed 属性中,简化了代码结构。

Copy link

coderabbitai bot commented Nov 14, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

此次更改涉及多个组件的value属性处理方式,主要是将直接注入的字符串值更新为计算属性,默认值为"-"。这要求在组件的渲染函数中以value.value的方式访问value,以确保正确的反应式更新。所有相关组件的控制流保持不变,主要集中在对value的处理和格式化逻辑的改进。

Changes

文件路径 更改摘要
packages/field/src/components/date-time/index.tsx value注入方式从字符串"-"更改为计算属性computed(() => "-")
packages/field/src/components/date/index.tsx value注入方式从字符串"-"更改为计算属性computed(() => "-")
packages/field/src/components/money/index.tsx value注入方式更改为计算属性,访问方式更新为value.value
packages/field/src/components/select/index.tsx value注入方式从字符串"-"更改为计算属性computed(() => "-"),更新fieldValue逻辑。
packages/field/src/components/text/index.tsx value注入方式更改为计算属性,访问方式更新为value.value
packages/field/src/components/time/index.tsx value注入方式更改为计算属性,访问方式更新为value.value
packages/field/src/field.tsx ProField组件中添加计算属性value,替换对props.value的直接使用。
packages/field/src/types.ts 更新ProFieldProps接口中value属性的类型,从any更改为ComputedRef<any>
packages/table/src/Table.tsx 移除formatTableColumns函数,将其逻辑集成到computed属性tableColumns中。

Possibly related PRs

  • feat: pro-field #126: 此PR的更改涉及引入与表单字段相关的新依赖,可能增强DateTimeMoneySelect等组件处理注入值的能力,与本PR中对value属性处理的更改相一致。

Poem

在田野中跳跃的兔子,
看到变化真是开心,
value从串到计算,
反应灵敏如春风,
组件更活泼,
让我们一起欢庆这新生! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@liujiayii liujiayii merged commit f95b66f into master Nov 14, 2024
3 checks passed
@liujiayii liujiayii deleted the feature/table branch November 14, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant