remove config

liuneng1994 · Mar 20, 2024 · 862abf2 · 862abf2
1 parent a29d4f5
commit 862abf2
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 4 deletions.
diff --git a/src/Analyzer/Passes/ConvertInToEqualPass.cpp b/src/Analyzer/Passes/ConvertInToEqualPass.cpp
@@ -24,8 +24,6 @@ class ConvertInToEqualPassVisitor : public InDepthQueryTreeVisitorWithContext<Co
 
     void enterImpl(QueryTreeNodePtr & node)
     {
-        if (!getSettings().optimize_in_to_equal)
-            return;
         auto * func_node = node->as<FunctionNode>();
         if (!func_node || func_node->getFunctionName() != "in" || func_node->getArguments().getNodes().size() != 2)
             return ;

diff --git a/src/Core/Settings.h b/src/Core/Settings.h
@@ -593,7 +593,6 @@ class IColumn;
     M(Bool, optimize_functions_to_subcolumns, false, "Transform functions to subcolumns, if possible, to reduce amount of read data. E.g. 'length(arr)' -> 'arr.size0', 'col IS NULL' -> 'col.null' ", 0) \
     M(Bool, optimize_using_constraints, false, "Use constraints for query optimization", 0)                                                                                                                                           \
     M(Bool, optimize_substitute_columns, false, "Use constraints for column substitution", 0)                                                                                                                                         \
-    M(Bool, optimize_in_to_equal, true, "Convert the constant in to equal", 0)   \
     M(Bool, optimize_append_index, false, "Use constraints in order to append index condition (indexHint)", 0) \
     M(Bool, optimize_time_filter_with_preimage, true, "Optimize Date and DateTime predicates by converting functions into equivalent comparisons without conversions (e.g. toYear(col) = 2023 -> col >= '2023-01-01' AND col <= '2023-12-31')", 0) \
     M(Bool, normalize_function_names, true, "Normalize function names to their canonical names", 0) \

diff --git a/src/Core/SettingsChangesHistory.h b/src/Core/SettingsChangesHistory.h
@@ -96,7 +96,6 @@ static std::map<ClickHouseVersion, SettingsChangesHistory::SettingsChanges> sett
               {"parallel_replicas_allow_in_with_subquery", false, true, "If true, subquery for IN will be executed on every follower replica"},
               {"filesystem_cache_reserve_space_wait_lock_timeout_milliseconds", 1000, 1000, "Wait time to lock cache for sapce reservation in filesystem cache"},
               {"max_parser_backtracks", 0, 1000000, "Limiting the complexity of parsing"},
-              {"optimize_in_to_equal", false, true, "Convert in single value to equal"},
               }},
     {"24.2", {{"allow_suspicious_variant_types", true, false, "Don't allow creating Variant type with suspicious variants by default"},
               {"validate_experimental_and_suspicious_types_inside_nested_types", false, true, "Validate usage of experimental and suspicious types inside nested types"},