feat(llm): add ChatContext #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incomplete implementation, notably missing tool call hooks (see comment for more info).
🦋 Changeset detectedLatest commit: c4cfdee The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nbsp
changed the title
theomonnom
reviewed
Oct 31, 2024
| inferenceWidth?: number; | ||
| inferenceHeight?: number; | ||
| /** Used by LLM implementations to store a processed version of the image for later use. */ | ||
| cache: { [id: string | number | symbol]: any }; |
There was a problem hiding this comment.
any way to make sure "cache" is private?
There was a problem hiding this comment.
to what degree? LLM needs direct access to it, so we can't make it private or readonly. i can mark is as @internal so it's clear only llms should use it
theomonnom
approved these changes
Nov 2, 2024
theomonnom
reviewed
Nov 2, 2024
| previous_item_id: previousItemId, | ||
| }); | ||
| // create(item: api_proto.ConversationItemCreateContent, previousItemId?: string): void { | ||
| create(message: llm.ChatMessage, previousItemId?: string): void { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
incomplete implementation, notably missing tool call hooks (see comment
for more info).