Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tts,stt): add StreamAdapter #156

Merged
merged 13 commits into from
Nov 15, 2024
Merged

feat(tts,stt): add StreamAdapter #156

merged 13 commits into from
Nov 15, 2024

Conversation

nbsp
Copy link
Member

@nbsp nbsp commented Nov 12, 2024

No description provided.

STT StreamAdapter still in the works, blocked by a VAD issue.
Copy link

changeset-bot bot commented Nov 12, 2024

🦋 Changeset detected

Latest commit: 8101e9b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@livekit/agents Patch
@livekit/agents-plugin-silero Patch
@livekit/agents-plugin-deepgram Patch
@livekit/agents-plugin-elevenlabs Patch
@livekit/agents-plugin-openai Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nbsp nbsp requested a review from a team November 12, 2024 22:02
@nbsp nbsp marked this pull request as draft November 13, 2024 11:34
@nbsp
Copy link
Member Author

nbsp commented Nov 13, 2024

STT seems to work well enough, but the TTS StreamAdapter fails in weird ways.

@nbsp nbsp changed the title feat(tts): add StreamAdapter feat(tts,stt): add StreamAdapter Nov 14, 2024
@nbsp
Copy link
Member Author

nbsp commented Nov 14, 2024

only thing left to tackle: OpenAI TTS doesn't allow for function calling. i assume the culprit is speech never ending on function calls, because there's no text to be called

@nbsp nbsp marked this pull request as ready for review November 14, 2024 23:25
this.queue.put(SynthesizeStream.END_OF_STREAM);
};

Promise.all([forwardInput(), synthesize()]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this closed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forwardInput gets closed via endInput to the stream, which flushes the queue and eventually synthesize finishes processing

@nbsp nbsp merged commit cb500cb into main Nov 15, 2024
4 checks passed
@nbsp nbsp deleted the nbsp/add/stream-adapter/tts branch November 15, 2024 07:20
@github-actions github-actions bot mentioned this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants