-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(treewide): native CommonJS #176
Conversation
🦋 Changeset detectedLatest commit: 4362e23 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
this still doesn't work. also the example i've been testing with, multimodal_agent.js, doesn't compile right, and needs tsx to run. pnpm exec tsx src/multimodal_agent.ts dev --log-level debug see that even though there are debug logs and plain console logs, none of them show up, and something gets stuck there. perhaps an unresolvable promise detection that exits with 13 without telling us? unsure.
now builds and runs, with following caveats:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm apart from the protocol version!
agents/package.json
Outdated
"@livekit/mutex": "^1.1.0", | ||
"@livekit/protocol": "^1.27.1", | ||
"@livekit/mutex": "^1.1.1", | ||
"@livekit/protocol": "^1.28.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be 1.29.1
fixes #121, fixes #147, fixes #157
tested with VPA and MMA.
depends on updates to the rest of the deptree to support CJS first.