chore(treewide): native CommonJS #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4362e23 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
this still doesn't work. also the example i've been testing with,
multimodal_agent.js, doesn't compile right, and needs tsx to run.
pnpm exec tsx src/multimodal_agent.ts dev --log-level debug
see that even though there are debug logs and plain console logs, none
of them show up, and something gets stuck there. perhaps an unresolvable
promise detection that exits with 13 without telling us? unsure.
|
now builds and runs, with following caveats:
|
lukasIO
approved these changes
Nov 28, 2024
agents/package.json
Outdated
| "@livekit/mutex": "^1.1.0", | ||
| "@livekit/protocol": "^1.27.1", | ||
| "@livekit/mutex": "^1.1.1", | ||
| "@livekit/protocol": "^1.28.1", |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #121, fixes #147, fixes #157
tested with VPA and MMA.
depends on updates to the rest of the deptree to support CJS first.