Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(treewide): native CommonJS #176

Merged
merged 17 commits into from
Nov 29, 2024
Merged

chore(treewide): native CommonJS #176

merged 17 commits into from
Nov 29, 2024

Conversation

nbsp
Copy link
Member

@nbsp nbsp commented Nov 21, 2024

fixes #121, fixes #147, fixes #157

tested with VPA and MMA.
depends on updates to the rest of the deptree to support CJS first.

Copy link

changeset-bot bot commented Nov 21, 2024

🦋 Changeset detected

Latest commit: 4362e23

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@livekit/agents Minor
@livekit/agents-plugin-deepgram Major
@livekit/agents-plugin-elevenlabs Major
@livekit/agents-plugin-openai Major
@livekit/agents-plugin-silero Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

nbsp added 4 commits November 22, 2024 02:50
this still doesn't work. also the example i've been testing with,
multimodal_agent.js, doesn't compile right, and needs tsx to run.

    pnpm exec tsx src/multimodal_agent.ts dev --log-level debug

see that even though there are debug logs and plain console logs, none
of them show up, and something gets stuck there. perhaps an unresolvable
promise detection that exits with 13 without telling us? unsure.
@nbsp
Copy link
Member Author

nbsp commented Nov 22, 2024

now builds and runs, with following caveats:

  • ts-mutex has to be vendored with type: module removed (currently it serves ESM on both mjs and js)
  • log fails, despite running off of same exact file, will look into it later

@nbsp nbsp marked this pull request as ready for review November 26, 2024 15:57
@nbsp nbsp requested review from lukasIO and bcherry November 26, 2024 15:57
Copy link
Contributor

@lukasIO lukasIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm apart from the protocol version!

"@livekit/mutex": "^1.1.0",
"@livekit/protocol": "^1.27.1",
"@livekit/mutex": "^1.1.1",
"@livekit/protocol": "^1.28.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be 1.29.1

@nbsp nbsp merged commit 35fc428 into main Nov 29, 2024
4 checks passed
@nbsp nbsp deleted the nbsp/chore/cjs branch November 29, 2024 08:10
@github-actions github-actions bot mentioned this pull request Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants