Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(silero): allow partial VAD options #183

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

hamza-ghufran
Copy link
Contributor

fixes: #182

Copy link

changeset-bot bot commented Nov 22, 2024

🦋 Changeset detected

Latest commit: b87e3b0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@livekit/agents-plugin-silero Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hamza-ghufran hamza-ghufran changed the title chore(silero): allow flexible option configuration in vad chore(silero): allow partial VAD options while maintaining defaults Nov 22, 2024
@nbsp
Copy link
Member

nbsp commented Nov 22, 2024

looks good, but can do without the changes to the documentation — this pattern already exists throughout the rest of the framework

@hamza-ghufran
Copy link
Contributor Author

@nbsp removed the example doc, please take a look.

@nbsp nbsp changed the title chore(silero): allow partial VAD options while maintaining defaults chore(silero): allow partial VAD options Nov 22, 2024
@nbsp nbsp merged commit 2e5f40e into livekit:main Nov 22, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VAD Load Options Enhancement
2 participants