Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a couple of bugs #184

Merged
merged 4 commits into from
Nov 25, 2024
Merged

Fix a couple of bugs #184

merged 4 commits into from
Nov 25, 2024

Conversation

posobin
Copy link
Contributor

@posobin posobin commented Nov 25, 2024

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 97cbdf9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Nov 25, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

posobin
posobin commented Nov 25, 2024
View reviewed changes
agents/src/pipeline/pipeline_agent.ts

const msg = ChatMessage.create({ text: collectedText, role: ChatRole.ASSISTANT });
this.chatCtx.messages.push(msg);
if (handle.addToChatCtx && (!userQuestion || handle.userCommitted)) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was nested in an if when I think it wasn't supposed to be so AGENT_SPEECH_INTERRUPTED/COMMITTED were never firing

theomonnom
theomonnom approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@theomonnom theomonnom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@theomonnom theomonnom requested a review from nbsp November 25, 2024 08:29
nbsp
nbsp approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@nbsp nbsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks! just one nitpick and i'll merge it.

plugins/deepgram/src/stt.ts Outdated
@@ -261,12 +261,14 @@ export class SpeechStream extends stt.SpeechStream {
if (isFinal) {
this.queue.put({
type: stt.SpeechEventType.FINAL_TRANSCRIPT,
alternatives: [alternatives[0], ...alternatives.splice(0)],
// Ensures that TS knows that the array is not empty
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you delete these comments? these are helpful at review time but not so much as code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't agree (would have been useful to me when reading this code), but sure, removed

@nbsp nbsp merged commit c6ee751 into livekit:main Nov 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbsp nbsp nbsp approved these changes

@theomonnom theomonnom theomonnom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@posobin @CLAassistant @theomonnom @nbsp