-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for additional deepgram config #1020
base: main
Are you sure you want to change the base?
support for additional deepgram config #1020
Conversation
🦋 Changeset detectedLatest commit: 2288c3f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
support for additional deepgram configs
Hey, I think it would be better to explicitly support those fields inside the constructor? |
Hey, thanks for the feedback! Sorry for getting back late on this one. I completely understand the idea of making paragraph and diarize explicit in the constructor. However,I would like to highlight why keeping additional_config as the main way to pass deepgram parameters is a more scalable and flexible approach: Avoids Frequent PRs & Code Changes Maximizes Flexibility for Users Deepgram Already Handles Validation Explicit Parameters Can Be Restrictive please let me know what you think. thanks. |
Summary of Changes
1. Addition of
additional_config
ParameterSTTOptions
dataclass now includes anadditional_config
field, which is a dictionary for storing extra configuration parameters for deepgram.paragraph
anddiarize
when initializing theSTT
class.2. Integration of
additional_config
in STT InitializationSTT
class constructor now accepts anadditional_config
argument, which is then passed to theSTTOptions
dataclass._sanitize_options
method call.3. Dynamic Configuration Handling
_sanitize_options
method has been updated to incorporate additional configuration options specified inadditional_config
.Example Usage
Users can now initialize the
STT
class with additional configuration parameters as follows: