Set default identity for CreateSIPParticipant. (#982)

livekit · Feb 18, 2025 · 0a12e2c · 0a12e2c
1 parent bfe8101
commit 0a12e2c
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/.changeset/sip-outbound-identity-opt.md b/.changeset/sip-outbound-identity-opt.md
@@ -0,0 +1,5 @@
+---
+"github.com/livekit/protocol": patch
+---
+
+Remove SIP outbound number normalization for Telnyx.
diff --git a/rpc/sip.go b/rpc/sip.go
@@ -96,6 +96,10 @@ func NewCreateSIPParticipantRequest(
 	if req.IncludeHeaders != 0 {
 		includeHeaders = req.IncludeHeaders
 	}
+	participantIdentity := req.ParticipantIdentity
+	if participantIdentity == "" {
+		participantIdentity = "sip_" + req.SipCallTo
+	}
 
 	return &InternalCreateSIPParticipantRequest{
 		ProjectId:             projectID,
@@ -111,7 +115,7 @@ func NewCreateSIPParticipantRequest(
 		WsUrl:                 wsUrl,
 		Token:                 token,
 		RoomName:              req.RoomName,
-		ParticipantIdentity:   req.ParticipantIdentity,
+		ParticipantIdentity:   participantIdentity,
 		ParticipantName:       req.ParticipantName,
 		ParticipantMetadata:   req.ParticipantMetadata,
 		ParticipantAttributes: attrs,

diff --git a/rpc/sip_test.go b/rpc/sip_test.go
@@ -48,6 +48,7 @@ func TestNewCreateSIPParticipantRequest(t *testing.T) {
 		Username:            "user",
 		Password:            "pass",
 		RoomName:            "room",
+		ParticipantIdentity: "sip_+3333",
 		ParticipantMetadata: "meta",
 		Token:               "token",
 		WsUrl:               "url",
@@ -85,16 +86,17 @@ func TestNewCreateSIPParticipantRequest(t *testing.T) {
 		Username:            "user",
 		Password:            "pass",
 		RoomName:            "room",
-		ParticipantMetadata: "meta",
 		Token:               "token",
 		WsUrl:               "url",
 		Dtmf:                "1234#",
 		PlayDialtone:        true,
+		ParticipantIdentity: "sip_+3333",
 		ParticipantAttributes: map[string]string{
 			"extra":                "1",
 			livekit.AttrSIPCallID:  "call-id",
 			livekit.AttrSIPTrunkID: "trunk",
 		},
+		ParticipantMetadata: "meta",
 		Headers: map[string]string{
 			"X-A": "A",
 			"X-B": "B2",