Log Pion trace level logs at Debug level. #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to debug connectivity issues in a deploy. Need Pion trace level logs to check ICE details (candidates, STUN binding request/responses, etc.). So, log pion trace at Debugw instead of ignoring it.
paulwe
approved these changes
Sep 11, 2023
davidzhao
approved these changes
Sep 11, 2023
| } | ||
|
|
||
| func (l *logAdapter) Tracef(format string, args ...interface{}) { | ||
| // ignore trace |
There was a problem hiding this comment.
Should we do the l.shouldIgnore check with these?
There was a problem hiding this comment.
Intentional skip as we want verbose details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to debug connectivity issues in a deploy.
Need Pion trace level logs to check ICE details (candidates, STUN binding request/responses, etc.). So, log pion trace at Debugw instead of ignoring it.