-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add c2patool #702
Add c2patool #702
Conversation
Note that this will get it in the Docker image but not in the tarball archive that will run during a deploy - that'll need to happen via something like 2f584db. That said, this is making me feel like we should probably just generate that archive off of the Docker image anyway for simplicity |
Thanks for the comment. Right, generating the archive from Docker image would be great. Though, for this PR, I'll just add what you pointed out. |
.github/workflows/build.yaml
Outdated
apt update && apt install -y curl build-essential git | ||
curl https://sh.rustup.rs -sSf | sh -s -- -y | ||
source "$HOME/.cargo/env" | ||
cargo install c2patool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably this to match the other one?
cargo install c2patool | |
cargo install --version 0.6.2 c2patool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/marketplace/actions/cargo-install I find dedicated github actions working faster than manual installations. Maybe worth trying out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with tiny change
Co-authored-by: iameli-streams <[email protected]>
Thanks @pwilczynskiclearcode for the suggestion with the cargo GH Action! |
No description provided.