feat: improve error message for no orchestrators available #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
Add "(aside)" to your comment to have me ignore it. |
|
IMO this should be exposed through the stream status API - otherwise, it will not show up to users in the stream list view. But maybe I'm thinking about it the wrong way? |
seanhanca
reviewed
Dec 19, 2024
apps/app/app/api/streams/upsert.ts
Outdated
There was a problem hiding this comment.
revert this change, this is wrong. no need to check the condition here. this is create stream in livepeer studio
There was a problem hiding this comment.
revert this change, this is wrong. no need to check the condition here.
This commit reverts the orchestrator error handling changes in: - apps/app/components/stream/stream-form.tsx - apps/app/app/api/streams/upsert.ts The error handling improvements in try.tsx are preserved as requested. Co-Authored-By: [email protected] <[email protected]>
seanhanca
approved these changes
Dec 19, 2024
suhailkakar
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve error message for no orchestrators available
Changes
try.tsxto show a more user-friendly message when no orchestrators are availableTesting
Notes
Link to Devin run: https://app.devin.ai/sessions/2c4803549d3b4695bbad7dc8112ff181