deploy,doc: Address other PR comments

livepeer · Oct 10, 2023 · e4f6cd8 · e4f6cd8
1 parent fccc671
commit e4f6cd8
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 14 deletions.
diff --git a/deploy/deploy_delta_upgrade.ts b/deploy/deploy_delta_upgrade.ts
@@ -134,8 +134,6 @@ const func: DeployFunction = async function(hre: HardhatRuntimeEnvironment) {
         )
     }
 
-    await Treasury.renounceRole(roles.admin, deployer).then(tx => tx.wait())
-
     const LivepeerGovernor: LivepeerGovernor = await ethers.getContractAt(
         "LivepeerGovernor",
         livepeerGovernor.address
@@ -200,6 +198,8 @@ const func: DeployFunction = async function(hre: HardhatRuntimeEnvironment) {
         console.log("Pending governance actions:")
         console.log(JSON.stringify(governanceActions, null, 2))
     }
+
+    // deployer MUST renounce ADMIN role from the Treasury afterwards
 }
 
 func.tags = ["DELTA_UPGRADE"]

diff --git a/deploy/migrations.config.ts b/deploy/migrations.config.ts
@@ -140,7 +140,7 @@ const arbitrumMainnet = {
     bondingManager: {
         numActiveTranscoders: 100,
         unbondingPeriod: 7, // 7 rounds
-        treasuryRewardCutRate: 100000, // 10%
+        treasuryRewardCutRate: ethers.BigNumber.from(10).pow(26), // 10% in 27-digit precision
         treasuryBalanceCeiling: ethers.utils.parseEther("750000") // 750k LPT
     },
     broker: {

diff --git a/doc/upgrade.md b/doc/upgrade.md
@@ -28,7 +28,17 @@ After deployment, a file in the `deployments` directory containing the latest ad
 
 ## Verify Contract Code
 
-Verify the contract code on arbiscan.io.
+You can run the `etherscan-verify-deployments` task from this repository available as a `yarn` script:
+
+```
+yarn etherscan-verify --network arbitrumMainnet Contract1 Contract2 ...
+```
+
+Additionally, you can omit the contract names to verify all the contracts that have been deployed on the specified network.
+
+## Manual Verification
+
+If the above script does not work, you can manually verify the contract code on arbiscan.io with the `hardhat-verify` plugin:
 
 ```
 npx hardhat verify --network arbitrumMainnet DEPLOYED_CONTRACT_ADDRESS "Constructor argument 1" ...
@@ -52,16 +62,6 @@ You can also use Tenderly to manually submit contract code for [private verifica
 
 If you see an error related to multiple SPDX license identifiers, remove all SPDX license identifiers from `flattened.sol` except for a single one.
 
-## Task
-
-Alternatively, you can also run the `etherscan-verify-deployments` task from this repository available as a `yarn` script:
-
-```
-yarn etherscan-verify --network arbitrumMainnet Contract1 Contract2 ...
-```
-
-Additionally, you can omit the contract names to verify all the contracts deployed on the specified network.
-
 ## View Contract Diff
 
 Use the contract diff checker at https://arbiscan.io/contractdiffchecker to view the code diff between the current and new target implementation contracts in order to check that the verified code at address of the new target implementation contract contains the expected changes.