segmenter: Fix error handling #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also create startSegmentingLoop helper function to avoid some of the boilerplate repetition.
It is just for logs anyway but still
Not something that should be affecting task-runner, but I saw that and why not fix it.
Might fix task-runner memory as well
|
Maaaaybe this could be related to livepeer/task-runner#19 as well But not yet sure. Probably not. I need to take another look on that one. |
figintern
reviewed
Jun 12, 2022
|
|
||
| return err | ||
| startSegmentingLoop(ctx, "", inFile, stopAtFileEnd, stopAfter, skipFirst, segLen, useWallTime, out) | ||
| return nil |
figintern
reviewed
Jun 12, 2022
figintern
approved these changes
Jun 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix the error handling in the testers/segmenter which is used by all
file-segmenting logic in livepeer.com outside of mist.
This includes
task-runner, which is currently crashing anytime a segmentingerror happens on any task. Fixing that is the main objective of fixing this bug.
This fixes livepeer/task-runner#37