-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multistream: atomic add and remove targets from a given stream #1988
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
4f18058
to
9cfb549
Compare
@@ -1327,6 +1327,83 @@ | |||
} | |||
); | |||
|
|||
app.post( | |||
"/:id/multistream", | |||
authorizer({}), |
Check failure
Code scanning / CodeQL
Missing rate limiting High
authorization
} | ||
); | ||
|
||
app.delete("/:id/multistream/:targetId", authorizer({}), async (req, res) => { |
Check failure
Code scanning / CodeQL
Missing rate limiting High
authorization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some minor issues in the code which could have been easily caught on tests. Can you please include some unit tests here?
Other comments are mostly style/optional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat
What does this pull request do? Explain your changes. (required)
Allow atomic creation of targets into a given stream and atomic remove
Specific updates (required)
How did you test each of these updates (required)
Does this pull request close any open issues?
Screenshots (optional)
Checklist