Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multistream: atomic add and remove targets from a given stream #1988

Merged
merged 4 commits into from
Dec 7, 2023

Conversation

gioelecerati
Copy link
Member

What does this pull request do? Explain your changes. (required)

Allow atomic creation of targets into a given stream and atomic remove

Specific updates (required)

How did you test each of these updates (required)

Does this pull request close any open issues?

Screenshots (optional)

Checklist

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@gioelecerati gioelecerati requested a review from a team as a code owner December 6, 2023 17:12
Copy link

vercel bot commented Dec 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
livepeer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 7, 2023 11:07pm

@gioelecerati gioelecerati force-pushed the gio/multistream/atomic-add-remove branch from 4f18058 to 9cfb549 Compare December 6, 2023 17:12
@@ -1327,6 +1327,83 @@
}
);

app.post(
"/:id/multistream",
authorizer({}),

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
authorization
, but is not rate-limited.
}
);

app.delete("/:id/multistream/:targetId", authorizer({}), async (req, res) => {

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
authorization
, but is not rate-limited.
Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some minor issues in the code which could have been easily caught on tests. Can you please include some unit tests here?

Other comments are mostly style/optional.

packages/api/src/controllers/stream.ts Outdated Show resolved Hide resolved
packages/api/src/controllers/stream.ts Outdated Show resolved Hide resolved
packages/api/src/controllers/stream.ts Show resolved Hide resolved
packages/api/src/controllers/stream.ts Outdated Show resolved Hide resolved
packages/api/src/controllers/stream.ts Show resolved Hide resolved
packages/api/src/controllers/stream.ts Outdated Show resolved Hide resolved
packages/api/src/schema/api-schema.yaml Show resolved Hide resolved
packages/api/src/schema/api-schema.yaml Outdated Show resolved Hide resolved
@gioelecerati gioelecerati merged commit f5fa0de into master Dec 7, 2023
8 of 9 checks passed
@gioelecerati gioelecerati deleted the gio/multistream/atomic-add-remove branch December 7, 2023 23:21
Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants