Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api,www: Create deleted state for recordings #2309

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

victorges
Copy link
Member

What does this pull request do? Explain your changes. (required)

Fix for the display bug reported by user on issue PS-808.

Basically creates a deleted state for the recordings to show that in the dashboard
instead of "in progress" when the recording asset is deleted.

Specific updates (required)

  • Add new deleted field value on the API
  • Show the deleted status on the UI

How did you test each of these updates (required)
yarn test 🤷

Does this pull request close any open issues?

Fixes PS-808

Checklist

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@victorges victorges requested review from a team as code owners September 11, 2024 17:37
Copy link

linear bot commented Sep 11, 2024

Copy link

vercel bot commented Sep 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
livepeer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 5:37pm

@victorges victorges merged commit cbcbfb4 into master Sep 11, 2024
8 checks passed
@victorges victorges deleted the vg/fix/deleted-recordings branch September 11, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants