-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 修复circleci没有docker的问题 #483
Conversation
审核者指南 by Sourcery此 PR 向 CircleCI 配置中添加了架构和平台环境变量,以解决与 Docker 相关的问题。更改指定了所有作业配置中的 AMD64 架构和 Linux 平台。 未生成图表,因为更改看起来简单,不需要视觉表示。 文件级更改
提示和命令与 Sourcery 互动
自定义您的体验访问您的仪表板以:
获取帮助Original review guide in EnglishReviewer's Guide by SourceryThis PR adds architecture and platform environment variables to CircleCI configuration to fix Docker-related issues. The changes specify AMD64 architecture and Linux platform across all job configurations. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嗨 @livk-cloud - 我已经审查了你的更改 - 这里有一些反馈:
总体评论:
- 请添加一个描述,解释此 PR 修复的 Docker 问题以及为什么需要这些架构/平台规范。
- 考虑使用 CircleCI YAML 锚点或 orbs 来减少这些环境变量在作业中的重复。
这是我在审查期间查看的内容
- 🟢 一般问题:一切看起来都很好
- 🟢 安全性:一切看起来都很好
- 🟢 测试:一切看起来都很好
- 🟢 复杂性:一切看起来都很好
- 🟢 文档:一切看起来都很好
帮助我变得更有用!请点击每条评论上的 👍 或 👎,我将使用反馈来改进你的评论。
Original comment in English
Hey @livk-cloud - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please add a description explaining the Docker issue this PR is fixing and why these architecture/platform specifications are needed.
- Consider using CircleCI YAML anchors or orbs to reduce the duplication of these environment variables across jobs.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Quality Gate passedIssues Measures |
Summary by Sourcery
CI:
Original summary in English
Summary by Sourcery
CI: