-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: 设置部分分支运行 circleci #495
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: livk <[email protected]>
审核者指南 by Sourcery该 PR 修改了 CircleCI 配置,以限制 CI 作业的执行仅限于特定分支。实现为每个 JDK CI 作业添加了分支过滤器,限制其仅在 'main' 和 'dev-snapshot' 分支上运行。 未生成图表,因为更改看起来简单,不需要视觉表示。 文件级更改
提示和命令与 Sourcery 互动
自定义您的体验访问您的仪表板以:
获取帮助Original review guide in EnglishReviewer's Guide by SourceryThe PR modifies the CircleCI configuration to restrict CI job execution to specific branches. The implementation adds branch filters to each JDK CI job, limiting their execution to only run on 'main' and 'dev-snapshot' branches. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嗨 @livk-cloud - 我已经审查了你的更改 - 这里有一些反馈:
总体评论:
- 考虑添加有关 CI 策略的文档,以及为什么构建仅限于 main 和 dev-snapshot 分支。这将帮助新贡献者理解工作流程。
这是我在审查期间查看的内容
- 🟢 一般问题:一切看起来都很好
- 🟢 安全性:一切看起来都很好
- 🟢 测试:一切看起来都很好
- 🟢 复杂性:一切看起来都很好
- 🟢 文档:一切看起来都很好
帮助我变得更有用!请点击每条评论上的 👍 或 👎,我将使用反馈来改进你的评论。
Original comment in English
Hey @livk-cloud - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding documentation about the CI strategy and why builds are limited to main and dev-snapshot branches. This will help new contributors understand the workflow.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
CI:
Original summary in English
Summary by Sourcery
CI: