-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
polish #532
polish #532
Conversation
审阅者指南 by Sourcery此拉取请求重构了多个测试类,以使用 上下文接口变更的类图classDiagram
class Context {
<<interface>>
+create(Map~String,?~ map)$ Context
+putAll(Map~String,?~ m)* Context
+put(String key, Object value)* Context
+asMap() Map~String,Object~
}
class ContextImpl {
-Map~String,Object~ variables
+put(String key, Object value) Context
+putAll(Map~String,?~ m) Context
+asMap() Map~String,Object~
}
Context <|.. ContextImpl
note for Context "更改为密封接口"
note for ContextImpl "更改为非密封类"
文件级变更
提示和命令与 Sourcery 交互
自定义您的体验访问您的仪表板以:
获取帮助Original review guide in EnglishReviewer's Guide by SourceryThis pull request refactors several test classes to use Class diagram for Context interface changesclassDiagram
class Context {
<<interface>>
+create(Map~String,?~ map)$ Context
+putAll(Map~String,?~ m)* Context
+put(String key, Object value)* Context
+asMap() Map~String,Object~
}
class ContextImpl {
-Map~String,Object~ variables
+put(String key, Object value) Context
+putAll(Map~String,?~ m) Context
+asMap() Map~String,Object~
}
Context <|.. ContextImpl
note for Context "Changed to sealed interface"
note for ContextImpl "Changed to non-sealed class"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嘿 @livk-cloud - 我已经审查了你的更改,看起来非常棒!
以下是我在审查期间关注的内容
- 🟢 一般性问题:一切看起来都很好
- 🟢 安全性:一切看起来都很好
- 🟢 测试:一切看起来都很好
- 🟢 复杂性:一切看起来都很好
- 🟢 文档:一切看起来都很好
帮助我变得更有用!请在每条评论上点击 👍 或 👎,我将使用这些反馈来改进你的评论。
Original comment in English
Hey @livk-cloud - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Quality Gate passedIssues Measures |
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嘿 @livk-cloud - 我已经审查了你的更改,看起来非常棒!
以下是我在审查期间关注的内容
- 🟢 一般性问题:一切看起来都很好
- 🟢 安全性:一切看起来都很好
- 🟢 测试:一切看起来都很好
- 🟢 复杂性:一切看起来都很好
- 🟢 文档:一切看起来都很好
帮助我变得更有用!请在每条评论上点击 👍 或 👎,我将使用这些反馈来改进你的评论。
Original comment in English
Hey @livk-cloud - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
重构测试以使用 ApplicationContextRunner 和 WebApplicationContextRunner。
测试:
Original summary in English
Summary by Sourcery
Refactor tests to use ApplicationContextRunner and WebApplicationContextRunner.
Tests:
测试:
Original summary in English
Summary by Sourcery
重构测试以使用 ApplicationContextRunner 和 WebApplicationContextRunner。
测试:
Original summary in English
Summary by Sourcery
Refactor tests to use ApplicationContextRunner and WebApplicationContextRunner.
Tests: