Add automatic support in WebClient for JVM http.proxyHost and related…

… properties (helidon-io#7322) Signed-off-by: Jorge Bescos Gascon <[email protected]>
ljnelson · Aug 8, 2023 · f040c33 · f040c33
1 parent d396957
commit f040c33
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/webclient/webclient/src/main/java/io/helidon/webclient/Proxy.java b/webclient/webclient/src/main/java/io/helidon/webclient/Proxy.java
@@ -427,7 +427,7 @@ private Builder() {
         @Override
         public Proxy build() {
             if ((host == null || host.isEmpty()) && systemSelector == null) {
-                return NO_PROXY;
+                useSystemSelector(true);
             }
             return new Proxy(this);
         }

diff --git a/webclient/webclient/src/test/java/io/helidon/webclient/ProxyTest.java b/webclient/webclient/src/test/java/io/helidon/webclient/ProxyTest.java
@@ -166,6 +166,18 @@ void testDefaultProxyType() {
         assertThat(proxy.type(), is(Proxy.ProxyType.HTTP));
     }
 
+    @Test
+    void testDefaultSystem1() {
+        Proxy proxy = Proxy.create();
+        assertThat(proxy.type(), is(Proxy.ProxyType.SYSTEM));
+    }
+
+    @Test
+    void testDefaultSystem2() {
+        Proxy proxy = Proxy.create(Config.empty());
+        assertThat(proxy.type(), is(Proxy.ProxyType.SYSTEM));
+    }
+
     private void validateRelativizeNoProxy(WebClientConfiguration webConfig) {
         boolean relativeUris = webConfig.relativeUris();
         Proxy proxy = webConfig.proxy().get();