I added Azerbaijani Dataset

[ferid333]

I added Azerbaijani Dataset

[lk-geimfari]

Hi! Please see https://github.com/lk-geimfari/mimesis/tree/master/mimesis/datasets/locale_template

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.04%. Comparing base (4212746) to head (f7c6550).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1599      +/-   ##
==========================================
- Coverage   56.07%   56.04%   -0.03%     
==========================================
  Files          60       60              
  Lines        2190     2191       +1     
==========================================
  Hits         1228     1228              
- Misses        962      963       +1     

[ferid333]

Sorry I will fix

[lk-geimfari]

Hello. Everything works fine but there is problem related to language. In our language if a person is female, surname of her should be added 'a' at the end. For example, Afaq Qurbanova but for males Farid Qurbanov

Same in Russian. Please, refer to ru locale.

[ferid333]

I just update the surnames, everything is fine now and working

[lk-geimfari]

@ferid333 We're almost done. Please fix the tests and add locale to the table of locales: https://github.com/lk-geimfari/mimesis/blob/master/docs/locales.rst#supported-locales

[ferid333]

@lk-geimfari Error is related to this function: Where SUPPORTED_LOCALES_COUNT does not match
def test_locale_enum():

  assert len(list(Locale)) == SUPPORTED_LOCALES_COUNT

E AssertionError: assert 48 == 47
E + where 48 = len([<Locale.AR_AE: 'ar-ae'>, <Locale.AR_DZ: 'ar-dz'>, <Locale.AR_EG: 'ar-eg'>, <Locale.AR_JO: 'ar-jo'>, <Locale.AR_OM: 'ar-om'>, <Locale.AR_KW: 'ar-kw'>, ...])
E + where [<Locale.AR_AE: 'ar-ae'>, <Locale.AR_DZ: 'ar-dz'>, <Locale.AR_EG: 'ar-eg'>, <Locale.AR_JO: 'ar-jo'>, <Locale.AR_OM: 'ar-om'>, <Locale.AR_KW: 'ar-kw'>, ...] = list(Locale)

[lk-geimfari]

@lk-geimfari Error is related to this function: Where SUPPORTED_LOCALES_COUNT does not match def test_locale_enum():

  assert len(list(Locale)) == SUPPORTED_LOCALES_COUNT

E AssertionError: assert 48 == 47 E + where 48 = len([<Locale.AR_AE: 'ar-ae'>, <Locale.AR_DZ: 'ar-dz'>, <Locale.AR_EG: 'ar-eg'>, <Locale.AR_JO: 'ar-jo'>, <Locale.AR_OM: 'ar-om'>, <Locale.AR_KW: 'ar-kw'>, ...]) E + where [<Locale.AR_AE: 'ar-ae'>, <Locale.AR_DZ: 'ar-dz'>, <Locale.AR_EG: 'ar-eg'>, <Locale.AR_JO: 'ar-jo'>, <Locale.AR_OM: 'ar-om'>, <Locale.AR_KW: 'ar-kw'>, ...] = list(Locale)

Yeah, I know. Contributors must increment the SUPPORTED_LOCALES_COUNT when adding a locale.

[ferid333]

@lk-geimfari Error is related to this function: Where SUPPORTED_LOCALES_COUNT does not match def test_locale_enum():

  assert len(list(Locale)) == SUPPORTED_LOCALES_COUNT

E AssertionError: assert 48 == 47 E + where 48 = len([<Locale.AR_AE: 'ar-ae'>, <Locale.AR_DZ: 'ar-dz'>, <Locale.AR_EG: 'ar-eg'>, <Locale.AR_JO: 'ar-jo'>, <Locale.AR_OM: 'ar-om'>, <Locale.AR_KW: 'ar-kw'>, ...]) E + where [<Locale.AR_AE: 'ar-ae'>, <Locale.AR_DZ: 'ar-dz'>, <Locale.AR_EG: 'ar-eg'>, <Locale.AR_JO: 'ar-jo'>, <Locale.AR_OM: 'ar-om'>, <Locale.AR_KW: 'ar-kw'>, ...] = list(Locale)

Yeah, I know. Contributors must increment the SUPPORTED_LOCALES_COUNT when adding a locale.

Where is that ?

[lk-geimfari]

@ferid333

mimesis/tests/test_locales.py

Line 8 in 4212746

SUPPORTED_LOCALES_COUNT = 47

[ferid333]

@lk-geimfari I passed all tests

[lk-geimfari]

@ferid333 Please, resolve conflicts.

[lk-geimfari]

@ferid333 Some tests are still failing. Please, fix them. Thanks!

[ferid333]

@lk-geimfari What error is related to ? CHECK=1 bash scripts/format.sh
Running lint check
would reformat /home/runner/work/mimesis/mimesis/mimesis/datasets/int/code.py
would reformat /home/runner/work/mimesis/mimesis/tests/test_locales.py
would reformat /home/runner/work/mimesis/mimesis/mimesis/datasets/int/finance.py

Oh no! 💥 💔 💥
3 files would be reformatted, 111 files would be left unchanged.
make: *** [Makefile:20: format] Error 1

[lk-geimfari]

@ferid333 There are code style issues. You can fix them using make format

[ferid333]

@ferid333 There are code style issues. You can fix them using make format

I made

[ferid333]

@lk-geimfari What can be reason for that : @codecov
codecov
/ codecov/patch
mimesis/enums.py#L81
Added line #L81 was not covered by tests

[lk-geimfari]

@ferid333 You forgot to lock dependencies after removing isort. Please lock deps, using poetry lock. Thank you!

[lk-geimfari]

@ferid333 We’re done. I’ll merge the PR later after a detailed review on my machine. Thank you!

[ferid333]

@ferid333 We’re done. I’ll merge the PR later after a detailed review on my machine. Thank you!

Thank you

[ferid333]

Hello! Could you merge ?

[lk-geimfari]

@ferid333 Sorry, I've been busy as hell these past few months.