Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add other missing imports #8

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Add other missing imports #8

merged 1 commit into from
Jul 1, 2024

Conversation

waifod
Copy link
Collaborator

@waifod waifod commented Jun 30, 2024

We try to fix the workflow failures by adding missing imports.

@waifod
Copy link
Collaborator Author

waifod commented Jun 30, 2024

Alright, it looks like the build issues are fixed, but now there's a test failure due to an exception being thrown.

From what I see, the tests do not expect failures, and since locally they were running fine (when they were running), this failure may come from some undefined behavior. Hooray!

@lluiscamino
Copy link
Owner

Tests failure is so weird! It's failing in this line. It's like if the program was trying to do a binary operation with an identifier as the token (e.g. a IDENTIFIER b instead of a = b).

We should add a try catch and log which test failed and try to debug from there. I can work on this when I have time, if you don't want to take a look at it. Or if you want, go ahead!

@waifod
Copy link
Collaborator Author

waifod commented Jul 1, 2024

I agree on adding logs, but I don't like exceptions as they are generally considered bad practices.

As I said already, we should also add a testing framework to facilitate things.

@waifod waifod merged commit 03a0398 into lluiscamino:main Jul 1, 2024
1 check failed
@waifod waifod deleted the import branch July 1, 2024 18:22
@lluiscamino
Copy link
Owner

Yeah, eventually I wanted to add some kind of errors logger than saves all of the parsing or execution errors and displays them to the user. So that if there's multiple errors in a problem we log all of them instead of exiting the program in the first found error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants