add logs and check browser exists before checking process()

lluisd · Feb 13, 2024 · 525445e · 525445e
1 parent b0c4f02
commit 525445e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/helpers/browserApi.js b/helpers/browserApi.js
@@ -17,8 +17,9 @@ class PuppeteerApi {
     async createNewBrowser() {
         this.browser = await puppeteer.connect({ browserWSEndpoint: config.browserlessUrl })
         this.browser.on('disconnected', async () => {
+            console.log('disconnected browser')
             if (this.browser) await this.browser.close()
-            if (this.browser.process() != null) this.browser.process().kill('SIGINT')
+            if (this.browser && this.browser.process() != null) this.browser.process().kill('SIGINT')
             this.browser = null
         })
     }

diff --git a/services/browser.js b/services/browser.js
@@ -30,10 +30,12 @@ async function startAndWarmUpBrowserIfNeeded() {
     const browserIsOpen = await browserApi.checkIfBrowserIsOpen()
 
     if (!browserIsOpen) {
+        console.log('Browser is not open, creating new one')
         await browserApi.createNewBrowser()
     }
     const pageIsOpen = await browserApi.checkIfPageIsOpen()
     if (!pageIsOpen) {
+        console.log('Page is not open, creating new one')
         await browserApi.createNewPage()
     }
 }