[RISCV][NFC] Fix a warning

[pfusik]

No description provided.

[llvmbot]

@llvm/pr-subscribers-backend-risc-v

Author: Piotr Fusik (pfusik)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/127090.diff

1 Files Affected:

• (modified) llvm/lib/Target/RISCV/RISCVVMV0Elimination.cpp (+4-4)

diff --git a/llvm/lib/Target/RISCV/RISCVVMV0Elimination.cpp b/llvm/lib/Target/RISCV/RISCVVMV0Elimination.cpp
index efd92c55e3adf..ccc86da340440 100644
--- a/llvm/lib/Target/RISCV/RISCVVMV0Elimination.cpp
+++ b/llvm/lib/Target/RISCV/RISCVVMV0Elimination.cpp
@@ -159,10 +159,10 @@ bool RISCVVMV0Elimination::runOnMachineFunction(MachineFunction &MF) {
         if (MO.isReg() && MO.getReg().isVirtual() &&
             MRI.getRegClass(MO.getReg()) == &RISCV::VMV0RegClass) {
           MRI.recomputeRegClass(MO.getReg());
-          assert(MRI.getRegClass(MO.getReg()) != &RISCV::VMV0RegClass ||
-                 MI.isInlineAsm() ||
-                 MRI.getVRegDef(MO.getReg())->isInlineAsm() &&
-                     "Non-inline-asm use of vmv0 left behind");
+          assert((MRI.getRegClass(MO.getReg()) != &RISCV::VMV0RegClass ||
+                  MI.isInlineAsm() ||
+                  MRI.getVRegDef(MO.getReg())->isInlineAsm()) &&
+                 "Non-inline-asm use of vmv0 left behind");
         }
       }
     }

[lukel97]

LGTM, thanks

[lukel97]

Looks like my version of Clang isn't reporting this. Were you seeing this on GCC/a newer Clang?

[pfusik]

gcc version 11.4.0 (Ubuntu 11.4.0-1ubuntu1~22.04)

/home/p.fusik/upstream/llvm-project/llvm/lib/Target/RISCV/RISCVVMV0Elimination.cpp: In member function ‘virtual bool {anonymous}::RISCVVMV0Elimination::runOnMachineFunction(llvm::MachineFunction&)’:
/home/p.fusik/upstream/llvm-project/llvm/lib/Target/RISCV/RISCVVMV0Elimination.cpp:164: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses]
  164 |                  MRI.getVRegDef(MO.getReg())->isInlineAsm() &&
      |                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  165 |                      "Non-inline-asm use of vmv0 left behind");
      |