Fix(web-react): HeaderDialog is now closable on backdrop click

- Dialog component now have default value `true` on closeOnBackdropClick solve #DS-1075
lmc-eu · Dec 1, 2023 · 6cd4c84 · 6cd4c84
1 parent 30490e6
commit 6cd4c84
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/packages/web-react/src/components/Dialog/Dialog.tsx b/packages/web-react/src/components/Dialog/Dialog.tsx
@@ -7,7 +7,7 @@ import { useCancelEvent, useClickOutside } from '../../hooks';
 // Solved using `as MutableRefObject<HTMLDialogElement | null>` but I do not like it
 
 const Dialog = (props: DialogProps, ref: ForwardedRef<HTMLDialogElement | null>): JSX.Element => {
-  const { children, isOpen, onClose, closeOnBackdropClick, ...restProps } = props;
+  const { children, isOpen, onClose, closeOnBackdropClick = true, ...restProps } = props;
   const dialogElementRef: MutableRefObject<ForwardedRef<HTMLDialogElement | null>> = useRef(ref);
   const contentElementRef: MutableRefObject<HTMLElement | null> = useRef(null);
 

diff --git a/packages/web-react/src/components/Modal/Modal.tsx b/packages/web-react/src/components/Modal/Modal.tsx
@@ -7,7 +7,7 @@ import { ModalProvider } from './ModalContext';
 import Dialog from '../Dialog/Dialog';
 
 const Modal = (props: SpiritModalProps) => {
-  const { children, isOpen, onClose, closeOnBackdropClick = true, id, ...restProps } = props;
+  const { children, isOpen, onClose, id, ...restProps } = props;
   const { classProps } = useModalStyleProps();
   const { styleProps, props: otherProps } = useStyleProps(restProps);
 
@@ -27,7 +27,6 @@ const Modal = (props: SpiritModalProps) => {
         id={id}
         isOpen={isOpen}
         onClose={onClose}
-        closeOnBackdropClick={closeOnBackdropClick}
         className={classNames(classProps.root, styleProps.className)}
         aria-labelledby={`${id}__title`}
       >