-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(design-tokens): Introduce structure of exported tokens to JS #1101
Conversation
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
✅ Deploy Preview for spirit-design-system-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-validations canceled.
|
✅ Deploy Preview for spirit-design-system-react canceled.
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit cfcc21c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
d50498c
to
1d3bf3d
Compare
9422b0c
to
4c49c0c
Compare
a00dbd0
to
50cb350
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this is several PRs merged into one. It is quite hard to navigate through this PR, especially without any README. I assume we need some at least for the Offcanvas plugin, because now only you know how to set the breakpoint. So please document this better.
Also, I am a bit afraid if it won't break anything, as you modify a lot of files and packages, but hopefully it won't. Also I didn't find the CSS variable implementation?
7fa5fdc
to
f8c4f9a
Compare
Try to go commit-by-commit. The build process is a little bit complicated because design tokens must be built first.
This was a problem with the rebase I have made. The CSS variable was added by me and also I have introduced the Offcanvas Readme. |
690ba33
to
bd577b0
Compare
c61bf50
to
e96c830
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few small fixes and it is hopefully ready to merge
* there are dependencies between some packages * paths between packages must be resolvable by lints and tests
70b4890
to
fabd72d
Compare
Description
Additional context
Issue reference
Before submitting the PR, please make sure you do the following
fixes #123
).