Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs(web, web-twig, web-react): Document ModalHeader and ModalFooter … #1126

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

crishpeen
Copy link
Member

…usage recommendations #DS-1033

Description

Additional context

Issue reference

DS-1033


Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

netlify bot commented Nov 2, 2023

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 568b416
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/654cc6d29a37f90008176828
😎 Deploy Preview https://deploy-preview-1126--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 2, 2023
Copy link

netlify bot commented Nov 2, 2023

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 568b416
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/654cc6d260cf2c00082ae4f3

Copy link

netlify bot commented Nov 2, 2023

Deploy Preview for spirit-design-system-demo ready!

Name Link
🔨 Latest commit 568b416
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/654cc6d226dd50000842f4ac
😎 Deploy Preview https://deploy-preview-1126--spirit-design-system-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Nov 2, 2023

Coverage Status

coverage: 79.853% (-5.0%) from 84.896%
when pulling 4180cc0 on docs/modal-footer-header-recommended
into 3c0f08b on main.

Copy link

netlify bot commented Nov 2, 2023

Deploy Preview for spirit-design-system-react ready!

Name Link
🔨 Latest commit 568b416
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/654cc6d214e9560008817340
😎 Deploy Preview https://deploy-preview-1126--spirit-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Nov 2, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 568b416. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried to suggest some modifications to the copy. They are not exactly clear to me 🤔

packages/web-react/src/components/Modal/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Modal/README.md Outdated Show resolved Hide resolved
packages/web-twig/src/Resources/components/Modal/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Modal/README.md Outdated Show resolved Hide resolved
@crishpeen crishpeen force-pushed the docs/modal-footer-header-recommended branch from b651fcc to 4180cc0 Compare November 7, 2023 10:11
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@crishpeen crishpeen force-pushed the docs/modal-footer-header-recommended branch from 4180cc0 to 568b416 Compare November 9, 2023 11:47
@crishpeen crishpeen merged commit 403cc0b into main Nov 9, 2023
31 checks passed
@crishpeen crishpeen deleted the docs/modal-footer-header-recommended branch November 9, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants