-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deps: Update dependency stylelint to v16 #1539
Conversation
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
025e05b
to
299c7e5
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
I updated our codebase to match the new rules. The rest is IMHO up to you @literat. |
Great, thanks. So let's check lmc-eu/code-quality-tools#175 so I can release the BC and use it here :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you guys for pushing this forward. 🙏🏻 I was struggling so much with the build so I gave up.
I'm happy to see the styles are ready to work with the latest Stylelint. 👍🏻
This is what I think needs to be done next:
- fix the build who-knows-how 💥 🤷🏻♂️
- finish the CQT config upgrade
- possibly a standalone topic: extend CQT order config with rule blocks and new properties
- install the latest CQT config here
- review our rules to see if they can be moved to CQT – I think everything except the "unstable" and unit test overrides can (and should) be shared or dropped so the configuration is as streamlined as possible 🙏🏻
Build failure is caused by the local path used in |
Please, see lmc-eu/code-quality-tools#180 |
🤔 This (https://github.com/lmc-eu/spirit-design-system/blob/main/configs/stylelint-config-spirit/rules/style.js) is the only rule, except the |
cd67ab6
to
abd1870
Compare
abd1870
to
e3bd387
Compare
32d30a8
to
2b75ba1
Compare
This PR contains the following updates:
15.11.0
->16.6.1
^15.11.0
->^15.11.0 || ^16.0.0
Release Notes
stylelint/stylelint (stylelint)
v16.6.1
Compare Source
no-descending-specificity
false positives for nested selectors (#7724) (@romainmenke).selector-type-no-unknown
false positive formodel
(#7718) (@Mouvedia).v16.6.0
Compare Source
function-calc-no-unspaced-operator
false negatives (#7655 & #7670 & #7676) (@ybiquitous & @romainmenke).selector-not-notation
autofix of the"simple"
option (#7703) (@Mouvedia).selector-max-specificity
end positions (#7685) (@romainmenke).no-descending-specificity
end positions (#7701) (@romainmenke).npm fund
(#7707) (@ybiquitous).v16.5.0
Compare Source
ignoreValues
forvalue-no-vendor-prefix
(#7650) (@Mouvedia).shorthand-property-no-redundant-values
false negatives for functions (#7657) (@ybiquitous).value-no-vendor-prefix
false negatives/positives (#7654 & #7658) (@Mouvedia).CosmiconfigResult
type error (#7661) (@ybiquitous).v16.4.0
Compare Source
no-unknown-custom-media
(#7594) (@fpetrakov).ignoreLonghands: []
todeclaration-block-no-redundant-longhand-properties
(#7611) (@Mouvedia).ignore: ["keyframe-selectors"]
torule-selector-property-disallowed-list
(#7572) (@emmacharp).declaration-block-no-redundant-longhand-properties
autofix conflicts (#7626) (@Mouvedia).declaration-block-no-redundant-longhand-properties
autofix fortext-decoration
(#7611) (@Mouvedia).declaration-block-no-shorthand-property-overrides
false negatives forborder
(#7585) (@fpetrakov).declaration-block-no-shorthand-property-overrides
false negatives forfont
andborder
(#7606) (@Mouvedia).function-calc-no-unspaced-operator
false negatives for some math functions (#7619) (@Mouvedia).function-no-unknown
false positives foranchor
andanchor-size
(#7607) (@Mouvedia).selector-max-attribute
end positions (#7592) (@romainmenke).selector-max-class
end positions (#7590) (@romainmenke).selector-max-combinators
end positions (#7596) (@romainmenke).selector-max-compound-selectors
end positions (#7599) (@romainmenke).selector-max-pseudo-class
end positions (#7598) (@romainmenke).selector-max-universal
end positions (#7597) (@romainmenke).selector-type-no-unknown
false positives for experimental and deprecated HTML tags (#7612) (@Mouvedia).v16.3.1
Compare Source
selector-max-id
end positions (#7571) (@romainmenke)./index.js
(#7578) (@ota-meshi).v16.3.0
Compare Source
ignoreSelectors: []
toselector-max-compound-selectors
(#7544) (@FloEdelmann).string
andverbose
formatters (#7539) (@m-allanson).*-deprecation
command-line flags of Node.js (#7550) (@fpetrakov).rule-selector-property-disallowed-list
false positives for nesting selectors (#7558) (@romainmenke).selector-pseudo-*-allowed-list
false positives for vendor prefixes (#7525) (@carlosjeurissen).report()
forindex
/endIndex
zero values (#7565) (@romainmenke).selector-max-type
end positions (#7518) (@romainmenke).v16.2.1
Compare Source
custom-property-no-missing-var-function
false positives for properties that can contain author-defined identifiers (#7478) (@ybiquitous).selector-pseudo-class-no-unknown
false positives for:seeking
, the media loading state and sound state pseudo-classes (#7490) (@Mouvedia).selector-max-specificity
false positives withignoreSelectors
option forof <selector>
syntax (#7475) (@ybiquitous).function-calc-no-unspaced-operator
performance (#7505) (@ybiquitous).validateOptions
to report when secondary option object is an empty object or null (#7476) (@ybiquitous).report()
error message responsibility for a missing node or line number (#7474) (@ybiquitous).v16.2.0
Compare Source
media-query-no-invalid
specific problem messages (#7462) (@romainmenke).checkContextFunctionalPseudoClasses: []
toselector-max-id
(#7380) (@brigitamaria).declaration-property-value-no-unknown
false negatives for@starting-style
(#7461) (@fpetrakov).function-no-unknown|value-keyword-case
false positives for template literals with line breaks (#7443) (@Sh031224).allowEmptyInput
option ignored in configuration object regression (#7446) (@ybiquitous).at-rule-no-unknown
false positives for@starting-style
(#7438) (@fpetrakov).ERR_UNSUPPORTED_ESM_URL_SCHEME
for--custom-formatter
on Windows (#7432) (@JounQin).Error: Could not find <package>
message clarity (#7456) (@jeddy3).overrides.files
negated pattern regression introduced in 15.0.0 (#7468) (@ybiquitous).v16.1.0
Compare Source
lightness-notation
rule (#7366) (@fpetrakov).ignore: ["keyframe-selectors"]
toselector-disallowed-list
(#7417) (@mattxwang).selector-pseudo-class-no-unknown
false positive for:popover-open
(#7425) (@mattxwang).declaration-property-value-no-unknown
and other false positives for multiline SCSS interpolation. (#7406) (@FloEdelmann).function-url-quotes
false positives for SCSS variable and@
character (#7416) (@mattxwang).v16.0.2
Compare Source
ERR_UNSUPPORTED_ESM_URL_SCHEME
error on Windows (#7383) (@JounQin).v16.0.1
Compare Source
v16.0.0
Compare Source
Migrating to
16.0.0
guide.stylelint.formatters
object to havePromise
values (#7184) (@ybiquitous).fix
regardless of extension (#7357) (@ybiquitous).stylelint.rules
object to havePromise
values (#7279) (@ybiquitous).stylelint.utils.checkAgainstRule
to be an async function (#7339) (@ybiquitous).output
property in a Node.js API returned object. Instead,report
/code
properties are recommended (#7183) (@ybiquitous) & (@haocheng6).exports
field topackage.json
for Conditional Exports (ESM/CommonJS) (#7307) (@ybiquitous).severity
secondary option's function support (#7202) (@kizu).Promise
formatter function (#7184) (@ybiquitous).report
/code
properties to a Node.js API returned object (#7183) (@ybiquitous) & (@haocheng6)..js
extension to.mjs
and.cjs
(#7307) (@ybiquitous).Configuration
📅 Schedule: Branch creation - "after 9am and before 5pm on the 2nd and 4th day instance on Monday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate. View repository job log here.