Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deps: Update dependency stylelint to v16 #1539

Merged
merged 4 commits into from
Aug 8, 2024
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 3, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
stylelint (source) 15.11.0 -> 16.6.1 age adoption passing confidence
stylelint (source) ^15.11.0 -> ^15.11.0 || ^16.0.0 age adoption passing confidence

Release Notes

stylelint/stylelint (stylelint)

v16.6.1

Compare Source

v16.6.0

Compare Source

v16.5.0

Compare Source

v16.4.0

Compare Source

v16.3.1

Compare Source

v16.3.0

Compare Source

v16.2.1

Compare Source

  • Fixed: report flags not reporting on subsequent runs when cache is used (#​7483) (@​ybiquitous).
  • Fixed: custom-property-no-missing-var-function false positives for properties that can contain author-defined identifiers (#​7478) (@​ybiquitous).
  • Fixed: selector-pseudo-class-no-unknown false positives for :seeking, the media loading state and sound state pseudo-classes (#​7490) (@​Mouvedia).
  • Fixed: selector-max-specificity false positives with ignoreSelectors option for of <selector> syntax (#​7475) (@​ybiquitous).
  • Fixed: function-calc-no-unspaced-operator performance (#​7505) (@​ybiquitous).
  • Fixed: validateOptions to report when secondary option object is an empty object or null (#​7476) (@​ybiquitous).
  • Fixed: report() error message responsibility for a missing node or line number (#​7474) (@​ybiquitous).

v16.2.0

Compare Source

v16.1.0

Compare Source

v16.0.2

Compare Source

v16.0.1

Compare Source

v16.0.0

Compare Source

Migrating to 16.0.0 guide.


Configuration

📅 Schedule: Branch creation - "after 9am and before 5pm on the 2nd and 4th day instance on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from literat as a code owner July 3, 2024 21:27
@renovate renovate bot added the dependencies Pull requests that update a dependency file label Jul 3, 2024
@renovate renovate bot requested review from adamkudrna, crishpeen, pavelklibani, curdaj and a team as code owners July 3, 2024 21:27
Copy link

netlify bot commented Jul 3, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 2b75ba1
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/66b4a557e16b33000848870f

Copy link

netlify bot commented Jul 3, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 2b75ba1
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66b4a5576b6b5a0008fb1262
😎 Deploy Preview https://deploy-preview-1539--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@renovate renovate bot force-pushed the dependencies/stylelint-16.x branch from 025e05b to 299c7e5 Compare July 4, 2024 08:03
Copy link
Contributor Author

renovate bot commented Jul 4, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@crishpeen
Copy link
Member

I updated our codebase to match the new rules. The rest is IMHO up to you @literat.

@literat
Copy link
Collaborator

literat commented Jul 19, 2024

I updated our codebase to match the new rules. The rest is IMHO up to you @literat.

Great, thanks. So let's check lmc-eu/code-quality-tools#175 so I can release the BC and use it here :-)

Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you guys for pushing this forward. 🙏🏻 I was struggling so much with the build so I gave up.

I'm happy to see the styles are ready to work with the latest Stylelint. 👍🏻

This is what I think needs to be done next:

  • fix the build who-knows-how 💥 🤷🏻‍♂️
  • finish the CQT config upgrade
  • possibly a standalone topic: extend CQT order config with rule blocks and new properties
  • install the latest CQT config here
  • review our rules to see if they can be moved to CQT – I think everything except the "unstable" and unit test overrides can (and should) be shared or dropped so the configuration is as streamlined as possible 🙏🏻

configs/stylelint-config-spirit/package.json Outdated Show resolved Hide resolved
configs/stylelint-config-spirit/package.json Outdated Show resolved Hide resolved
packages/design-tokens/package.json Outdated Show resolved Hide resolved
packages/web/src/scss/tools/_breakpoint.scss Outdated Show resolved Hide resolved
configs/stylelint-config-spirit/plugins/prettier.js Outdated Show resolved Hide resolved
@literat
Copy link
Collaborator

literat commented Aug 5, 2024

This is what I think needs to be done next:

  • fix the build who-knows-how 💥 🤷🏻‍♂️

Build failure is caused by the local path used in package.json. After publishing the new CQT package version and using it instead, it will work again.

@literat
Copy link
Collaborator

literat commented Aug 5, 2024

[ ] possibly a standalone topic: extend CQT order config with rule blocks and new properties

Please, see lmc-eu/code-quality-tools#180

@literat
Copy link
Collaborator

literat commented Aug 5, 2024

  • review our rules to see if they can be moved to CQT – I think everything except the "unstable" and unit test overrides can (and should) be shared or dropped so the configuration is as streamlined as possible 🙏🏻

🤔 This (https://github.com/lmc-eu/spirit-design-system/blob/main/configs/stylelint-config-spirit/rules/style.js) is the only rule, except the unstable_ prefix that differs from CQT. So I think the configuration is pretty streamlined already.

@literat literat force-pushed the dependencies/stylelint-16.x branch from cd67ab6 to abd1870 Compare August 7, 2024 13:34
@coveralls
Copy link

coveralls commented Aug 7, 2024

Coverage Status

coverage: 78.364% (+4.6%) from 73.772%
when pulling 2b75ba1 on dependencies/stylelint-16.x
into bc55dd9 on main.

@literat literat force-pushed the dependencies/stylelint-16.x branch from abd1870 to e3bd387 Compare August 7, 2024 14:18
@literat literat requested a review from adamkudrna August 7, 2024 14:29
configs/stylelint-config-spirit/rules/style.js Outdated Show resolved Hide resolved
packages/web/src/scss/tools/_breakpoint.scss Outdated Show resolved Hide resolved
@literat literat force-pushed the dependencies/stylelint-16.x branch from 32d30a8 to 2b75ba1 Compare August 8, 2024 11:00
@literat literat merged commit 2cd0f17 into main Aug 8, 2024
14 of 15 checks passed
@literat literat deleted the dependencies/stylelint-16.x branch August 8, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants