Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(web, web-react, web-twig): Add alignmentX and alignmentY to Grid component #1575

Merged
merged 4 commits into from
Aug 23, 2024
Merged

Feat(web, web-react, web-twig): Add alignmentX and alignmentY to Grid component #1575

merged 4 commits into from
Aug 23, 2024

Conversation

pavelklibani
Copy link
Contributor

@pavelklibani pavelklibani commented Aug 13, 2024 •
edited
Loading

Description

Additional context

Issue reference

DS-1414 - Komponenta Grid | Add props to align items

@pavelklibani pavelklibani self-assigned this Aug 13, 2024
@github-actions github-actions bot added the feature New feature or request label Aug 13, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 13, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 8c7e0d3
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66c876c7ccec5e0008e74062
😎 Deploy Preview https://deploy-preview-1575--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Aug 13, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 8c7e0d3
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/66c876c735d6ed00085abdfa

@coveralls
Copy link

coveralls commented Aug 13, 2024 •
edited
Loading

Coverage Status

coverage: 78.449% (+0.01%) from 78.435%
when pulling 8c7e0d3 on feat/ds-1414-grid-props
into 7ba942c on main.

@pavelklibani pavelklibani changed the title Feat(web): Add alignmentX and alignmentY classes to Grid component #D… Feat(web, web-react, web-twig): Add alignmentX and alignmentY to Grid component Aug 13, 2024
@pavelklibani pavelklibani marked this pull request as ready for review August 13, 2024 09:29
crishpeen
crishpeen reviewed Aug 13, 2024
View reviewed changes
Copy link
Member

@crishpeen crishpeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First review, please implement my suggestions and the stuff we discussed.

packages/web-react/src/components/Grid/README.md Show resolved Hide resolved
packages/web-react/src/components/Grid/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Grid/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Grid/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Grid/__tests__/Grid.test.tsx Show resolved Hide resolved
packages/web/src/scss/components/Grid/_Grid.scss Outdated Show resolved Hide resolved
packages/web/src/scss/components/Grid/_Grid.scss Outdated Show resolved Hide resolved
packages/web/src/scss/components/Grid/_Grid.scss Outdated Show resolved Hide resolved
packages/web/src/scss/components/Grid/_theme.scss Show resolved Hide resolved
packages/web/src/scss/components/Grid/index.html Outdated Show resolved Hide resolved
@pavelklibani pavelklibani force-pushed the feat/ds-1414-grid-props branch from d45ea24 to 085d34a Compare August 13, 2024 13:08
adamkudrna
adamkudrna reviewed Aug 13, 2024
View reviewed changes
docs/DICTIONARIES.md Outdated Show resolved Hide resolved
@pavelklibani pavelklibani force-pushed the feat/ds-1414-grid-props branch from b6b74ff to 6d6be6f Compare August 20, 2024 09:22
adamkudrna
adamkudrna reviewed Aug 20, 2024
View reviewed changes
Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Great job.

packages/web-react/src/components/Grid/__tests__/Grid.test.tsx Show resolved Hide resolved
packages/web-react/src/components/Grid/__tests__/Grid.test.tsx Show resolved Hide resolved
packages/web-react/src/components/Grid/__tests__/useGridStyleProps.test.tsx Show resolved Hide resolved
packages/web-react/src/components/Grid/demo/GridAlignment.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/Grid/demo/GridAlignment.tsx Outdated Show resolved Hide resolved
packages/web-twig/src/Resources/components/Grid/__tests__/__fixtures__/grid.twig Outdated Show resolved Hide resolved
packages/web-twig/src/Resources/components/Grid/stories/GridAlignment.twig Show resolved Hide resolved
packages/web/src/scss/components/Grid/README.md Outdated Show resolved Hide resolved
packages/web/src/scss/components/Grid/README.md Outdated Show resolved Hide resolved
packages/web/src/scss/components/Grid/README.md Outdated Show resolved Hide resolved
@pavelklibani pavelklibani force-pushed the feat/ds-1414-grid-props branch 4 times, most recently from 50d2344 to cb1e1d2 Compare August 20, 2024 14:07
adamkudrna
adamkudrna requested changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for changes. Better testes have just helped us find out there is a serious thing to resolve 🙂.

packages/web-react/src/components/Grid/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Grid/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Grid/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Grid/__tests__/Grid.test.tsx Outdated Show resolved Hide resolved
packages/web-twig/src/Resources/components/Grid/README.md Outdated Show resolved Hide resolved
packages/web/src/scss/components/Grid/index.html Outdated Show resolved Hide resolved
packages/web/src/scss/components/Grid/index.html Outdated Show resolved Hide resolved
literat
literat approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

adamkudrna
adamkudrna approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! 👏🏻

packages/web-twig/src/Resources/components/Grid/README.md Outdated Show resolved Hide resolved
packages/web-twig/src/Resources/components/Grid/Grid.twig Outdated Show resolved Hide resolved
packages/web-twig/src/Resources/components/Grid/Grid.twig Outdated Show resolved Hide resolved
@pavelklibani pavelklibani force-pushed the feat/ds-1414-grid-props branch from 442a5ff to 37724c0 Compare August 23, 2024 07:58
@pavelklibani pavelklibani force-pushed the feat/ds-1414-grid-props branch from 37724c0 to 94e9084 Compare August 23, 2024 07:59
@pavelklibani pavelklibani added the run-visual-tests Runs visual regression testing on this PR label Aug 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/10522113739/artifacts/1846055712

@pavelklibani pavelklibani force-pushed the feat/ds-1414-grid-props branch from 94e9084 to 3f05149 Compare August 23, 2024 11:35
@pavelklibani pavelklibani force-pushed the feat/ds-1414-grid-props branch from 3f05149 to 8c7e0d3 Compare August 23, 2024 11:47
@pavelklibani pavelklibani merged commit ef34f64 into main Aug 23, 2024
26 checks passed
@pavelklibani pavelklibani deleted the feat/ds-1414-grid-props branch August 23, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crishpeen crishpeen crishpeen left review comments

@curdaj curdaj curdaj approved these changes

@adamkudrna adamkudrna adamkudrna approved these changes

@literat literat literat approved these changes

Assignees

@pavelklibani pavelklibani

Labels
feature New feature or request run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pavelklibani @coveralls @literat @adamkudrna @crishpeen @curdaj