-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Example NextJS app with app router #DS-1393 #1578
Conversation
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
2c1f640
to
5c8a748
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only thing I am not sure about is that currently when I run make start
in the root of the repository, this example starts too, but in the next start
state.
I am not sure if we really want to do this. Or if we even want to start it or build it with all other packages and so on.
But we can fix this later too.
d3247a9
to
0d1b89a
Compare
Description
Additional context
Issue reference