Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Example NextJS app with app router #DS-1393 #1578

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

curdaj
Copy link
Contributor

@curdaj curdaj commented Aug 14, 2024

Description

Additional context

Issue reference

@github-actions github-actions bot added the feature New feature or request label Aug 14, 2024
Copy link

netlify bot commented Aug 14, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 0d1b89a
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66c499c05202160008b0014a
😎 Deploy Preview https://deploy-preview-1578--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 14, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 0d1b89a
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/66c499c0bd0f6900087b012d

Copy link
Contributor

Coverage Status

coverage: 78.263%. remained the same
when pulling 7abd9d3 on feat/ds-1393-support-ssr-app-router
into 7b3ab46 on main.

@coveralls
Copy link

coveralls commented Aug 15, 2024

Coverage Status

coverage: 78.435%. remained the same
when pulling 0d1b89a on feat/ds-1393-support-ssr-app-router
into 1e0571b on main.

@curdaj curdaj force-pushed the feat/ds-1393-support-ssr-app-router branch from 2c1f640 to 5c8a748 Compare August 16, 2024 13:40
@curdaj curdaj marked this pull request as ready for review August 19, 2024 07:21
@curdaj curdaj requested a review from a team as a code owner August 19, 2024 07:21
examples/next-with-app-router/next.config.mjs Outdated Show resolved Hide resolved
examples/next-with-app-router/src/app/page.tsx Outdated Show resolved Hide resolved
examples/next-with-app-router/.eslintrc.json Outdated Show resolved Hide resolved
Copy link
Member

@crishpeen crishpeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only thing I am not sure about is that currently when I run make start in the root of the repository, this example starts too, but in the next start state.

I am not sure if we really want to do this. Or if we even want to start it or build it with all other packages and so on.

But we can fix this later too.

examples/next-with-app-router/README.md Outdated Show resolved Hide resolved
examples/next-with-app-router/README.md Outdated Show resolved Hide resolved
examples/next-with-app-router/README.md Outdated Show resolved Hide resolved
examples/next-with-app-router/.eslintrc.json Outdated Show resolved Hide resolved
@curdaj curdaj force-pushed the feat/ds-1393-support-ssr-app-router branch from d3247a9 to 0d1b89a Compare August 20, 2024 13:27
@curdaj curdaj merged commit 9e6d045 into main Aug 20, 2024
14 checks passed
@curdaj curdaj deleted the feat/ds-1393-support-ssr-app-router branch August 20, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants