Feat(web, web-react): Stabilization of ProductLogo #DS-1374 #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelklibani
requested review from
literat,
curdaj,
a team,
adamkudrna and
crishpeen
as code owners
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
crishpeen
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
LGTM except update of screens of homepages. You renamed the component, so you need to update them as well. (you probably didn't restart Vite, so the name change didn't apply, it checks the folder structure on initial load)
EDIT: My bad, we do not test them yet.
EDIT2: I merged Button, which reintroduced the HP screenshot tests, so I added them :)
crishpeen
force-pushed
the
integration/BC-v3-design-tokens
branch
from
240831b to
b3961b8
Compare
crishpeen
force-pushed
the
feat/ds-1374-stabilization-product-logo
branch
from
b7f756d to
174eb5f
Compare
crishpeen
force-pushed
the
feat/ds-1374-stabilization-product-logo
branch
from
174eb5f to
2ecf054
Compare
literat
approved these changes
Sep 6, 2024
pavelklibani
force-pushed
the
feat/ds-1374-stabilization-product-logo
branch
from
2ecf054 to
f97758b
Compare
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
rebased to trigger storybook deploy |
pavelklibani
merged commit fbdcc20
into
integration/BC-v3-design-tokens
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context
Issue reference
ProductLogo | Stabilization