Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(web): Switch FileUploader component to v3 design tokens #DS-1448 #1639

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

crishpeen
Copy link
Member

@crishpeen crishpeen commented Sep 12, 2024

Description

Additional context

Issue reference

@github-actions github-actions bot added the feature New feature or request label Sep 12, 2024
Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 9361779
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/66ec0f13a46e1f0008cc102c

Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 9361779
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66ec0f13b2893d00095a62f0
😎 Deploy Preview https://deploy-preview-1639--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 100 (🟢 up 7 from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@crishpeen crishpeen force-pushed the feat/v3-checkbox branch 2 times, most recently from 9890995 to 7f3837f Compare September 12, 2024 14:18
@literat
Copy link
Collaborator

literat commented Sep 13, 2024

Rebase is needed.

@crishpeen crishpeen force-pushed the feat/v3-checkbox branch 3 times, most recently from a433f13 to 22475dc Compare September 17, 2024 06:47
@coveralls
Copy link

coveralls commented Sep 17, 2024

Coverage Status

coverage: 78.69% (-0.8%) from 79.452%
when pulling 9361779 on feat/v3-fileuploader
into 8c59b37 on integration/BC-v3-design-tokens.

Base automatically changed from feat/v3-checkbox to integration/BC-v3-design-tokens September 17, 2024 08:46
@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch from 2b069f1 to e4c8059 Compare September 17, 2024 12:18
@crishpeen crishpeen force-pushed the feat/v3-fileuploader branch 2 times, most recently from e2251e4 to 97489e1 Compare September 17, 2024 14:43
Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things to fix. Snapshots need an update once the links stuff is merged.

@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch from 2d42419 to 70fab2b Compare September 19, 2024 11:09
@crishpeen crishpeen added the run-visual-tests Runs visual regression testing on this PR label Sep 19, 2024
Copy link
Contributor

@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch from 70fab2b to 8c59b37 Compare September 19, 2024 11:41
@crishpeen crishpeen merged commit e9452b3 into integration/BC-v3-design-tokens Sep 19, 2024
23 checks passed
@crishpeen crishpeen deleted the feat/v3-fileuploader branch September 19, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants