Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(web): Switch Footer component to v3 design tokens #1653

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

@crishpeen crishpeen added the run-visual-tests Runs visual regression testing on this PR label Sep 19, 2024
@github-actions github-actions bot added the feature New feature or request label Sep 19, 2024
Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 2176111
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/66ec4d7a4c4ab40008b3d7d8

Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 2176111
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66ec4d7a4914740008b6afde
😎 Deploy Preview https://deploy-preview-1653--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 100 (🟢 up 7 from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

packages/web/src/scss/components/Footer/README.md Outdated Show resolved Hide resolved
packages/web/src/scss/components/Footer/README.md Outdated Show resolved Hide resolved
packages/web/src/scss/components/Footer/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@coveralls
Copy link

coveralls commented Sep 19, 2024

Coverage Status

coverage: 74.199% (-5.3%) from 79.452%
when pulling 2176111 on feat/v3-footer
into 7c9caf7 on integration/BC-v3-design-tokens.

@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch from 7138575 to c3f52eb Compare September 19, 2024 15:09
@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch from c3f52eb to 7e531b9 Compare September 19, 2024 15:18
Copy link
Contributor

Copy link
Contributor

@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch from 7e531b9 to 7c9caf7 Compare September 19, 2024 15:48
@crishpeen crishpeen merged commit d2d3f54 into integration/BC-v3-design-tokens Sep 19, 2024
17 checks passed
@crishpeen crishpeen deleted the feat/v3-footer branch September 19, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants