Redesign the Handlebars demo app (Web, React, Form Validations) #DS-1479 #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
the
documentation
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
|
Very nice, looking forward 😅😅😅 |
|
Do not forget to update the snapshot tests in web-twig. |
adamkudrna
force-pushed
the
bc/header-v3-design-tokens
branch
from
8bbb8c1 to
e3b6dc0
Compare
Base automatically changed from
bc/header-v3-design-tokens
to
integration/BC-v3-design-tokens
October 1, 2024 09:32
adamkudrna
force-pushed
the
docs/redesign-with-theme-switcher
branch
from
c982a49 to
fd3e6f0
Compare
adamkudrna
force-pushed
the
docs/redesign-with-theme-switcher
branch
from
fd3e6f0 to
9bfd318
Compare
crishpeen
force-pushed
the
integration/BC-v3-design-tokens
branch
from
60a10d7 to
429c9e1
Compare
adamkudrna
force-pushed
the
integration/BC-v3-design-tokens
branch
from
429c9e1 to
ec062d6
Compare
crishpeen
force-pushed
the
integration/BC-v3-design-tokens
branch
from
ec062d6 to
a4baaa7
Compare
adamkudrna
force-pushed
the
docs/redesign-with-theme-switcher
branch
4 times, most recently
from
b0b34a4 to
a86bccf
Compare
I reduced the scope of this PR to the Handlebars demo only, without the theme switcher. More PRs are on their way! 🎉
|
adamkudrna
changed the title
adamkudrna
requested review from
literat,
pavelklibani,
curdaj,
a team and
crishpeen
as code owners
adamkudrna
force-pushed
the
docs/redesign-with-theme-switcher
branch
from
a86bccf to
c09a825
Compare
literat
approved these changes
Oct 3, 2024
crishpeen
reviewed
Oct 3, 2024
crishpeen
approved these changes
Oct 3, 2024
Include header and footer on all demo pages for easier navigation.
adamkudrna
force-pushed
the
docs/redesign-with-theme-switcher
branch
from
824634c to
6ebc564
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Include header and footer on all demo pages for easier navigation.
Additional context
Issue reference
https://jira.almacareer.tech/browse/DS-1479