Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(variables-scss): Fix SCSS typography font family export #1673

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

pavelklibani
Copy link
Contributor

Description

We need all font families to be enclosed in quotation
It was done in js files but not in scss.

- font-family: 'Inter', sans-serif,
+ font-family: "'Inter', sans-serif",

Note

We can either apply this condition or roll back to two-object solution.

Additional context

Issue reference

No 🤷‍♂️

@pavelklibani pavelklibani self-assigned this Oct 1, 2024
@pavelklibani pavelklibani requested review from literat, crishpeen, curdaj and a team as code owners October 1, 2024 11:39
@github-actions github-actions bot added the bug Something isn't working label Oct 1, 2024
@pavelklibani pavelklibani force-pushed the fix/export-scss-typography branch from 61a86eb to 9f65d9b Compare October 1, 2024 11:40
Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 3ce762d
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66fd362015cbdb0008b87b50
😎 Deploy Preview https://deploy-preview-1673--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 3ce762d
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/66fd3620d26094000802b33e

@coveralls
Copy link

coveralls commented Oct 2, 2024

Coverage Status

coverage: 78.761%. remained the same
when pulling 3ce762d on fix/export-scss-typography
into f2a263b on main.

Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pavelklibani pavelklibani force-pushed the fix/export-scss-typography branch from 7170dee to 3ce762d Compare October 2, 2024 12:01
@pavelklibani pavelklibani merged commit 0b45a68 into main Oct 2, 2024
14 checks passed
@pavelklibani pavelklibani deleted the fix/export-scss-typography branch October 2, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants