Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test(e2e): Enable Modal visual testing using v3 tokens #1674

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

@crishpeen crishpeen requested a review from a team as a code owner October 1, 2024 11:50
Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 2fda13c
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/66fbe1fb1881ed0008743310
😎 Deploy Preview https://deploy-preview-1674--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 2fda13c
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66fbe1fb305a3000089d3b01
😎 Deploy Preview https://deploy-preview-1674--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 100 (🟢 up 7 from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

Coverage Status

coverage: 78.791% (-18.0%) from 96.838%
when pulling 2fda13c on test/modal-v3
into a4baaa7 on integration/BC-v3-design-tokens.

Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@crishpeen crishpeen merged commit bc650cf into integration/BC-v3-design-tokens Oct 3, 2024
15 checks passed
@crishpeen crishpeen deleted the test/modal-v3 branch October 3, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants