BREAKING CHANGE: Button/ButtonLink have isSymmetrical prop instead of isSquare #DS-1484 #1681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
|
❗This is not a refactor, but BREAKING CHANGE. Please, change the commits accordingly :-) |
curdaj
requested review from
literat,
adamkudrna,
crishpeen,
pavelklibani and
a team
as code owners
curdaj
force-pushed
the
feat/ds-1484-button-rename-isSquare-to-isSymmetrical
branch
2 times, most recently
from
4cf96e5 to
1b8c9fb
Compare
curdaj
changed the title
pavelklibani
reviewed
Oct 3, 2024
packages/codemods/src/transforms/v3/web-react/__testfixtures__/button-prop-name.input.tsx
Outdated
Show resolved
Hide resolved
packages/codemods/src/transforms/v3/web-react/__testfixtures__/button-prop-name.output.tsx
Outdated
Show resolved
Hide resolved
packages/codemods/src/transforms/v3/web-react/__testfixtures__/buttonLink-prop-name.input.tsx
Outdated
Show resolved
Hide resolved
packages/codemods/src/transforms/v3/web-react/__testfixtures__/buttonLink-prop-name.output.tsx
Outdated
Show resolved
Hide resolved
adamkudrna
approved these changes
Oct 3, 2024
|
Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/11175903867/artifacts/2014604491 |
pavelklibani
approved these changes
Oct 4, 2024
curdaj
force-pushed
the
feat/ds-1484-button-rename-isSquare-to-isSymmetrical
branch
from
55334ad to
64e35a8
Compare
|
Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/11180334912/artifacts/2015796417 |
|
Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/11180334912/artifacts/2022554156 |
curdaj
force-pushed
the
feat/ds-1484-button-rename-isSquare-to-isSymmetrical
branch
from
64e35a8 to
77a17fb
Compare
literat
approved these changes
Oct 7, 2024
crishpeen
requested changes
Oct 8, 2024
packages/codemods/src/transforms/v3/web-react/button-prop-name.ts
Outdated
Show resolved
Hide resolved
packages/codemods/src/transforms/v3/web-react/__testfixtures__/button-prop-name.input.tsx
Outdated
Show resolved
Hide resolved
… instead of isSquare #DS-1484
…instead of isSquare #DS-1484
… of isSquare #DS-1484
curdaj
force-pushed
the
feat/ds-1484-button-rename-isSquare-to-isSymmetrical
branch
from
461f83c to
ad30bbe
Compare
curdaj
deleted the
feat/ds-1484-button-rename-isSquare-to-isSymmetrical
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context
Issue reference